Refactor bookmark tests to wait for URL change

Introduced a shared wait_for_url_change utility and updated all relevant Playwright bookmark tests to wait for the URL to change after clicking the bookmark button. This improves test reliability by ensuring the bookmark action completes before proceeding. Also added missing __init__.py files to ensure proper package structure.

Author: karangattu

tests/playwright/__init__.py

@@ -0,0 +1 @@
+# Makes playwright a package

tests/playwright/ai_generated_apps/__init__.py

@@ -0,0 +1 @@
+# Makes ai_generated_apps a package

tests/playwright/ai_generated_apps/bookmark/__init__.py

@@ -0,0 +1 @@
+# Makes bookmark a package

tests/playwright/ai_generated_apps/bookmark/accordion/test_accordion_bookmarking.py

@@ -3,6 +3,9 @@
 from shiny.playwright import controller
 from shiny.pytest import create_app_fixture
 from shiny.run import ShinyAppProc
+from tests.playwright.ai_generated_apps.bookmark.bookmark_utils import (
+    wait_for_url_change,
+)
 
 app = create_app_fixture(["app-express.py"])
 
@@ -19,10 +22,13 @@ def test_accordion_bookmarking_demo(page: Page, app: ShinyAppProc) -> None:
     acc_mod.expect_open(["Section A"])
     acc_mod.set(["Section C"])
 
+    existing_url = page.url
     # click bookmark button
     bookmark_button = controller.InputBookmarkButton(page)
     bookmark_button.click()
 
+    wait_for_url_change(page, existing_url)
+
     # reload page
     page.reload()
 
@@ -32,8 +38,12 @@ def test_accordion_bookmarking_demo(page: Page, app: ShinyAppProc) -> None:
     acc_single.set([])
     acc_mod.set([])
 
+    existing_url = page.url
+
     bookmark_button.click()
 
+    wait_for_url_change(page, existing_url)
+
     # reload page
     page.reload()
 

tests/playwright/ai_generated_apps/bookmark/bookmark_utils.py

@@ -0,0 +1,5 @@
+from playwright.sync_api import Page
+
+
+def wait_for_url_change(page: Page, existing_url: str, timeout: int = 5000):
+    page.wait_for_url(lambda url: url != existing_url, timeout=timeout)

tests/playwright/ai_generated_apps/bookmark/input_checkbox/test_input_checkbox_express_bookmarking.py

@@ -3,6 +3,9 @@
 from shiny.playwright import controller
 from shiny.pytest import create_app_fixture
 from shiny.run import ShinyAppProc
+from tests.playwright.ai_generated_apps.bookmark.bookmark_utils import (
+    wait_for_url_change,
+)
 
 app = create_app_fixture(["app-express.py"])
 
@@ -33,9 +36,12 @@ def test_checkbox_demo(page: Page, app: ShinyAppProc) -> None:
     module_checkbox.expect_checked(True)
     module_text.expect_value("Checkbox value: True")
 
+    existing_url = page.url
     bookmark_button = controller.InputBookmarkButton(page)
     bookmark_button.click()
 
+    wait_for_url_change(page, existing_url)
+
     # reload the page to test bookmark
     page.reload()
 

tests/playwright/ai_generated_apps/bookmark/input_checkbox_group/test_input_checkbox_group_express_bookmarking.py

@@ -3,6 +3,9 @@
 from shiny.playwright import controller
 from shiny.pytest import create_app_fixture
 from shiny.run import ShinyAppProc
+from tests.playwright.ai_generated_apps.bookmark.bookmark_utils import (
+    wait_for_url_change,
+)
 
 app = create_app_fixture(["app-express.py"])
 
@@ -35,9 +38,11 @@ def test_checkbox_group_demo(page: Page, app: ShinyAppProc) -> None:
     module_group.expect_selected(["Choice A", "Choice C"])
     module_text.expect_value("Checkbox group values: ('Choice A', 'Choice C')")
 
+    existing_url = page.url
     # Bookmark the state
     bookmark_button = controller.InputBookmarkButton(page)
     bookmark_button.click()
+    wait_for_url_change(page, existing_url)
 
     # Reload the page to test bookmark
     page.reload()

tests/playwright/ai_generated_apps/bookmark/input_file/test_input_file_express_bookmarking.py

@@ -3,6 +3,9 @@
 from shiny.playwright import controller
 from shiny.pytest import create_app_fixture
 from shiny.run import ShinyAppProc
+from tests.playwright.ai_generated_apps.bookmark.bookmark_utils import (
+    wait_for_url_change,
+)
 
 app = create_app_fixture(["app-express.py"])
 
@@ -44,9 +47,12 @@ def test_file_input_bookmarking(page: Page, app: ShinyAppProc) -> None:
 
     mod_file_output_txt.expect_value("File name(s): users.csv, users2.csv")
 
+    existing_url = page.url
+
     # click bookmark button
     bookmark_button = controller.InputBookmarkButton(page)
     bookmark_button.click()
+    wait_for_url_change(page, existing_url)
 
     page.reload()
 

tests/playwright/ai_generated_apps/bookmark/input_password/test_input_password_express_bookmarking.py

@@ -3,6 +3,9 @@
 from shiny.playwright import controller
 from shiny.pytest import create_app_fixture
 from shiny.run import ShinyAppProc
+from tests.playwright.ai_generated_apps.bookmark.bookmark_utils import (
+    wait_for_url_change,
+)
 
 app = create_app_fixture(["app-express.py"])
 
@@ -46,8 +49,11 @@ def test_text_input_demo(page: Page, app: ShinyAppProc) -> None:
 
     # click bookmark button
     bookmark_button = controller.InputBookmarkButton(page)
+    existing_url = page.url
     bookmark_button.click()
 
+    wait_for_url_change(page, existing_url)
+
     page.reload()
 
     # Check if the values are retained after reloading the page

tests/playwright/ai_generated_apps/bookmark/navsets/test_navsets_express_bookmarking.py

@@ -6,6 +6,9 @@
 from shiny.playwright import controller
 from shiny.pytest import create_app_fixture
 from shiny.run import ShinyAppProc
+from tests.playwright.ai_generated_apps.bookmark.bookmark_utils import (
+    wait_for_url_change,
+)
 
 app = create_app_fixture("app-express.py")
 
@@ -44,9 +47,11 @@ def test_navsets_bookmarking_demo(
     mod_navset_cont = navset_controller(page, f"first-{navset_name}_{navset_variant}")
     mod_navset_cont.set(f"{navset_name}_b")
 
+    existing_url = page.url
+
     # Click bookmark button
     controller.InputBookmarkButton(page).click()
-
+    wait_for_url_change(page, existing_url)
     # Reload page
     page.reload()
 
@@ -55,3 +60,4 @@ def test_navsets_bookmarking_demo(
     navset_cont.expect_value(f"{navset_name}_c")
     mod_navset_collection.expect_value(navset_name)
     mod_navset_cont.expect_value(f"{navset_name}_b")
+    mod_navset_cont.expect_value(f"{navset_name}_b")