Finishing visibility tests

Author: elnelson575

examples/dynamic-tabs/README.md

@@ -8,7 +8,7 @@
         ui.input_action_button("addFoo", "Add New 'Foo' tab")
 
     with ui.navset_tab(id="set"):
-        with ui.nav_panel("Hello"):
+        with ui.nav_panel("Hello", value="Hello"):
             "This is the hello tab"
         with ui.nav_panel("Foo", value="Foo"):
             "This is the Foo tab"
@@ -22,9 +22,12 @@
     @reactive.event(input.add)
     def _():
         id = "Dynamic-" + str(input.add())
+        with ui.hold() as new_panel:
+            with ui.nav_panel(id, value=id):
+                pass
         ui.nav_insert(
             "tabs",
-            ui.nav_panel(id, value=id),
+            new_panel,
             target="s2",
             position="before",
         )
@@ -38,9 +41,12 @@ def _():
     @reactive.event(input.addFoo)
     def _():
         n = str(input.addFoo())
+        with ui.hold() as new_panel:
+            with ui.nav_panel("Foo-" + n, value="Foo"):
+                "This is the new Foo-" + n + " tab"
         ui.nav_insert(
             "tabs",
-            ui.nav_panel("Foo-" + n, "This is the new Foo-" + n + " tab", value="Foo"),
+            new_panel[0],
             target="Menu",
             position="before",
             select=True,

examples/dynamic-tabs/requirements.txt

@@ -36,20 +36,20 @@ def nav_insert(
     Parameters
     ----------
     id
-        The ``id`` of the relevant navigation container (i.e., ``navset_*()`` object).
+        The `id` of the relevant navigation container (i.e., `navset_*()` object).
     nav_panel
         The navigation item to insert (typically a :func:`~shiny.ui.nav_panel` or
         :func:`~shiny.ui.nav_menu`). A :func:`~shiny.ui.nav_menu` isn't allowed when the
-        ``target`` references an :func:`~shiny.ui.nav_menu` (or an item within it). A
-        string is only allowed when the ``target`` references a
+        `target` references an :func:`~shiny.ui.nav_menu` (or an item within it). A
+        string is only allowed when the `target` references a
         :func:`~shiny.ui.nav_menu`.
     target
-        The ``value`` of an existing :func:`shiny.ui.nav` item, next to which tab will
-        be added. Can also be ``None``; see ``position``.
+        The `value` of an existing :func:`shiny.ui.nav` item, next to which tab will
+        be added. Can also be `None`; see `position`.
     position
         The position of the new nav item relative to the target nav item. If
-        ``target=None``, then ``"before"`` means the new nav item should be inserted at
-        the head of the navlist, and ``"after"`` is the end.
+        `target=None`, then `"before"` means the new nav item should be inserted at
+        the head of the navlist, and `"after"` is the end.
     select
         Whether the nav item should be selected upon insertion.
     session
@@ -92,17 +92,16 @@ def nav_insert(
     session._send_message_sync({"shiny-insert-tab": msg})
 
 
-@add_example()
 def nav_remove(id: str, target: str, session: Optional[Session] = None) -> None:
     """
     Remove a nav item from a navigation container.
 
     Parameters
     ----------
     id
-        The ``id`` of the relevant navigation container (i.e., ``navset_*()`` object).
+        The `id` of the relevant navigation container (i.e., `navset_*()` object).
     target
-        The ``value`` of an existing :func:`shiny.ui.nav_panel` item to remove.
+        The `value` of an existing :func:`shiny.ui.nav_panel` item to remove.
     session
         A :class:`~shiny.Session` instance. If not provided, it is inferred via
         :func:`~shiny.session.get_current_session`.
@@ -171,17 +170,16 @@ def nav_show(
     session._send_message_sync({"shiny-change-tab-visibility": msg})
 
 
-@add_example()
 def nav_hide(id: str, target: str, session: Optional[Session] = None) -> None:
     """
     Hide a navigation item
 
     Parameters
     ----------
     id
-        The ``id`` of the relevant navigation container (i.e., ``navset_*()`` object).
+        The `id` of the relevant navigation container (i.e., `navset_*()` object).
     target
-        The ``value`` of an existing :func:`shiny.ui.nav` item to hide.
+        The `value` of an existing :func:`shiny.ui.nav` item to hide.
     session
         A :class:`~shiny.Session` instance. If not provided, it is inferred via
         :func:`~shiny.session.get_current_session`.

shiny/api-examples/nav_insert/app-express.py

@@ -11,8 +11,8 @@
         ui.input_action_button("showMenu", "Show 'Static' nav_menu"),
     ),
     ui.navset_tab(
-        ui.nav_panel("Hello", "This is the hello tab"),
-        ui.nav_panel("Foo", "This is the Foo tab", value="Foo"),
+        ui.nav_panel("Hello", "This is the hello tab", value="Hello"),
+        ui.nav_panel("Foo", "Foo", value="Foo"),
         ui.nav_menu(
             "Static",
             ui.nav_panel("Static 1", "Static 1", value="s1"),
@@ -47,7 +47,7 @@ def _():
         n = str(input.addFoo())
         ui.nav_insert(
             "tabs",
-            ui.nav_panel("Foo-" + n, "This is the new Foo-" + n + " tab", value="Foo"),
+            ui.nav_panel("Foo-" + n, "Foo-" + n, value="Foo"),
             target="Menu",
             position="before",
             select=True,

shiny/ui/_navs_dynamic.py

@@ -0,0 +1,77 @@
+# import pytest
+import pytest
+from playwright.sync_api import Page, expect
+
+from shiny.playwright import controller
+from shiny.run import ShinyAppProc
+
+
+@pytest.mark.flaky(reruns=3, reruns_delay=2)
+def test_dynamic_navs(page: Page, local_app: ShinyAppProc) -> None:
+    page.goto(local_app.url)
+
+    # Page begins with 2 tabs: "Hello" and "Foo" and a nav menu with 2 static items.
+    navset_tab = controller.NavsetTab(page, "tabs")
+
+    # Click add-foo to add a new Foo tab
+    addfoo = controller.InputActionButton(page, "addFoo")
+    addfoo.click()
+    controller.NavsetTab(page, "tabs").expect_nav_titles(
+        ["Hello", "Foo", "Foo-1", "Static 1", "Static 2"]
+    )
+
+    # Click hide-tab to hide the Foo tabs
+    hidetab = controller.InputActionButton(page, "hideTab")
+    hidetab.click()
+
+    # Expect the Foo tabs to be hidden
+    expect(
+        page.get_by_role("presentation").filter(has_text="This is the Foo tab")
+    ).to_be_hidden()
+    expect(page.get_by_role("presentation").filter(has_text="Foo-")).to_be_hidden()
+
+    # Click show-tab to show the Foo tabs again
+    showtab = controller.InputActionButton(page, "showTab")
+    showtab.click()
+
+    # Expect the Foo tabs to be visible again
+    expect(
+        page.get_by_role("presentation").filter(has_text="This is the Foo tab")
+    ).not_to_be_hidden()
+    expect(page.get_by_role("presentation").filter(has_text="Foo-")).not_to_be_hidden()
+
+    # Click remove-foo to remove the Foo tabs
+    removefoo = controller.InputActionButton(page, "removeFoo")
+    removefoo.click()
+    controller.NavsetTab(page, "tabs").expect_nav_titles(
+        ["Hello", "Static 1", "Static 2"]
+    )
+
+    # Click add to add a dynamic tab
+    add = controller.InputActionButton(page, "add")
+    add.click()
+    controller.NavsetTab(page, "tabs").expect_nav_titles(
+        ["Hello", "Static 1", "Dynamic-1", "Static 2"]
+    )
+
+    # Click add again to add another dynamic tab
+    add.click()
+    controller.NavsetTab(page, "tabs").expect_nav_titles(
+        ["Hello", "Static 1", "Dynamic-1", "Dynamic-2", "Static 2"]
+    )
+
+    # Click hide-menu to hide the static menu
+    hidemenu = controller.InputActionButton(page, "hideMenu")
+    hidemenu.click()
+
+    # Expect the Menu to be hidden
+    expect(page.get_by_role("presentation").filter(has_text="Static")).to_be_hidden()
+
+    # Click show-menu to show the static menu again
+    showmenu = controller.InputActionButton(page, "showMenu")
+    showmenu.click()
+
+    # Expect the Menu to be visible again
+    expect(
+        page.get_by_role("presentation").filter(has_text="Static")
+    ).not_to_be_hidden()