Add expect_icon() method to controllers; update changelog

Author: cpsievert

CHANGELOG.md

@@ -9,20 +9,26 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### New features
 
-### Improvements
+* `ui.sidebar()` is now interactively resizable. (#2020)
 
-* `selectize`, `remove_button`, and `options` parameters of `ui.input_select()` have been deprecated; use `ui.input_selectize()` instead. (Thanks, @ErdaradunGaztea!) (#1947)
+* `ui.update_*()` functions now accept `ui.TagChild` (i.e., HTML) as input to the `label` and `icon` arguments. (#2020)
+
+* `playwright.controller.InputActionButton` gains a `expect_icon()` method. As a result, the already existing `expect_label()` no longer includes the icon. (#2020)
+
+### Improvements
 
 * Improved the styling and readability of markdown tables rendered by `ui.Chat()` and `ui.MarkdownStream()`. (#1973)
 
+* `selectize`, `remove_button`, and `options` parameters of `ui.input_select()` have been deprecated; use `ui.input_selectize()` instead. (Thanks, @ErdaradunGaztea!) (#1947)
+
 ### Bug fixes
 
+* Fixed an issue with `ui.Chat()` sometimes wanting to scroll a parent element. (#1996)
+
 * Explicitly call out module usage in UI input bookmark button documentation. (#1983)
 
 * Fix missing session when trying to display an error duing bookmarking. (#1984)
 
-* Fixed an issue with `ui.Chat()` sometimes wanting to scroll a parent element. (#1996)
-
 
 ## [1.4.0] - 2025-04-08
 

shiny/playwright/controller/_base.py

@@ -451,8 +451,6 @@ def expect_label(
         """
         Expect the label of the input button to have a specific value.
 
-        Note: This must include the icon if it is present!
-
         Parameters
         ----------
         value
@@ -461,7 +459,28 @@ def expect_label(
             The maximum time to wait for the expectation to be fulfilled. Defaults to `None`.
         """
 
-        self.expect.to_have_text(value, timeout=timeout)
+        loc_label = self.loc.locator(".action-label")
+        playwright_expect(loc_label).to_have_text(value, timeout=timeout)
+
+    def expect_icon(
+        self,
+        value: PatternOrStr,
+        *,
+        timeout: Timeout = None,
+    ) -> None:
+        """
+        Expect the icon of the input button to have a specific value.
+
+        Parameters
+        ----------
+        value
+            The expected value of the icon.
+        timeout
+            The maximum time to wait for the expectation to be fulfilled. Defaults to `None`.
+        """
+
+        loc_icon = self.loc.locator(".action-icon")
+        playwright_expect(loc_icon).to_have_text(value, timeout=timeout)
 
     def click(self, *, timeout: Timeout = None, **kwargs: object) -> None:
         """

tests/playwright/shiny/inputs/test_input_action_button_link.py

@@ -1,5 +1,5 @@
 from conftest import create_doc_example_core_fixture
-from playwright.sync_api import Page, expect
+from playwright.sync_api import Page
 
 from shiny.playwright import controller
 from shiny.run import ShinyAppProc
@@ -11,8 +11,8 @@ def test_input_action_kitchen(page: Page, app: ShinyAppProc) -> None:
     page.goto(app.url)
 
     button2 = controller.InputActionButton(page, "goButton2")
-    expect(button2.loc).to_have_text("🤩Go 2")
-    button2.expect_label("🤩Go 2")
+    button2.expect_label("Go 2")
+    button2.expect_icon("🤩")
     button2.expect_width(None)
 
     link = controller.InputActionLink(page, "goLink")
@@ -25,8 +25,9 @@ def test_input_action_kitchen(page: Page, app: ShinyAppProc) -> None:
 
     controller.InputActionButton(page, "update").click()
 
-    # TODO: why is the space needed here?
-    button1.expect_label("📅 New label")
+    button1.expect_label("New label")
+    button1.expect_icon("📅")
     button2.expect_label("Go 2")
     button3.expect_label("New label 3")
-    link.expect_label("🔗New link label")
+    link.expect_label("New link label")
+    link.expect_icon("🔗")