Add timeout handling for cell editing state checks

Updated OutputDataFrame to pass timeout to expect_cell_class for all cell state checks. Improved test reliability by adding retries and timeout when verifying cell enters editing state after pressing Enter.

Author: karangattu

shiny/playwright/controller/_output.py

@@ -1058,13 +1058,21 @@ def expect_class_state(
                 "cell-edit-editing", timeout=timeout
             )
         elif value == "editing":
-            self.expect_cell_class("cell-edit-editing", row=row, col=col)
+            self.expect_cell_class(
+                "cell-edit-editing", row=row, col=col, timeout=timeout
+            )
         elif value == "saving":
-            self.expect_cell_class("cell-edit-saving", row=row, col=col)
+            self.expect_cell_class(
+                "cell-edit-saving", row=row, col=col, timeout=timeout
+            )
         elif value == "failure":
-            self.expect_cell_class("cell-edit-failure", row=row, col=col)
+            self.expect_cell_class(
+                "cell-edit-failure", row=row, col=col, timeout=timeout
+            )
         elif value == "success":
-            self.expect_cell_class("cell-edit-success", row=row, col=col)
+            self.expect_cell_class(
+                "cell-edit-success", row=row, col=col, timeout=timeout
+            )
         else:
             raise ValueError(
                 "Invalid state. Select one of 'success', 'failure', 'saving', 'editing', 'ready'"
@@ -1096,6 +1104,9 @@ def _edit_cell_no_save(
 
         self._cell_scroll_if_needed(row=row, col=col, timeout=timeout)
         cell.dblclick(timeout=timeout)
+
+        # Wait for the cell to enter editing mode before filling the textarea
+        expect_to_have_class(cell, "cell-edit-editing", timeout=timeout)
         cell.locator("> textarea").fill(text)
 
     def set_sort(

tests/playwright/shiny/components/data_frame/validate_row_selection_edit_mode/test_validate_row_selection_edit_mode.py

@@ -61,11 +61,24 @@ def test_validate_row_selection_in_edit_mode(
     data_frame._edit_cell_no_save("Temp value", row=1, col=16)
     page.keyboard.press("Escape")
     page.keyboard.press("Enter")
-    data_frame.expect_class_state(
-        "editing",
-        row=1,
-        col=0,
-    )  # Stage column begins to be edited.
+
+    # This interaction (Enter key to start editing) can be flaky, so we retry if needed
+    max_retries = 3
+    for attempt in range(max_retries):
+        try:
+            page.wait_for_timeout(100)
+            data_frame.expect_class_state(
+                "editing",
+                row=1,
+                col=0,
+                timeout=1000,
+            )
+            break
+        except AssertionError:
+            if attempt < max_retries - 1:
+                page.keyboard.press("Enter")
+            else:
+                raise
 
     # Click outside the table/Press Escape to exit row focus.
     # Tab to the column name, hit enter. Verify the table becomes sorted.