Skip to content

Commit 8b982af

Browse files
committed
Add notes on why a temp dir is used
1 parent 663f028 commit 8b982af

File tree

2 files changed

+8
-0
lines changed

2 files changed

+8
-0
lines changed

tests/playwright/shiny/bookmark/dir/app-attr.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,10 @@ def called_restored():
4242
did_save = False
4343
did_restore = False
4444

45+
# Note:
46+
# This is a "temp" directory that is only used for testing and is cleaned up on app
47+
# shutdown. This should NOT be standard behavior of a hosting environment. Instead, it
48+
# should have a persistent directory that can be restored over time.
4549
bookmark_dir = Path(__file__).parent / f"bookmarks-{rand_hex(8)}"
4650
bookmark_dir.mkdir(exist_ok=True)
4751

tests/playwright/shiny/bookmark/dir/app-global.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,10 @@ def called_restored():
4343
did_save = False
4444
did_restore = False
4545

46+
# Note:
47+
# This is a "temp" directory that is only used for testing and is cleaned up on app
48+
# shutdown. This should NOT be standard behavior of a hosting environment. Instead, it
49+
# should have a persistent directory that can be restored over time.
4650
bookmark_dir = Path(__file__).parent / f"bookmarks-{rand_hex(8)}"
4751
bookmark_dir.mkdir(exist_ok=True)
4852

0 commit comments

Comments
 (0)