Skip to content

Commit 8c9c910

Browse files
committed
use consistent timezone
1 parent 6ffc625 commit 8c9c910

File tree

3 files changed

+27
-28
lines changed

3 files changed

+27
-28
lines changed

tests/playwright/shiny/tests_for_ai_generated_apps/input_slider/app-core.py

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
1-
from datetime import date, datetime
1+
from datetime import datetime
22
from zoneinfo import ZoneInfo
33

44
from shiny import App, reactive, render, ui
55

66
# Define a consistent timezone
7-
TIMEZONE = ZoneInfo("Asia/Singapore")
7+
TIMEZONE = ZoneInfo("UTC")
88

99
app_ui = ui.page_fluid(
1010
ui.panel_title("Slider Parameters Demo"),
@@ -37,11 +37,10 @@
3737
ui.input_slider(
3838
"slider4",
3939
"Select a date",
40-
min=date(2023, 1, 1),
41-
max=date(2023, 12, 31),
42-
value=date(2023, 6, 15),
40+
min=datetime(2023, 1, 1, 0, 0, tzinfo=TIMEZONE),
41+
max=datetime(2023, 12, 31, 0, 0, tzinfo=TIMEZONE),
42+
value=datetime(2023, 6, 15, 12, 30, tzinfo=TIMEZONE),
4343
time_format="%Y-%m-%d",
44-
timezone="Asia/Singapore",
4544
),
4645
ui.output_text("value4"),
4746
),
@@ -89,7 +88,7 @@
8988
datetime(2023, 9, 30, 0, 0, tzinfo=TIMEZONE),
9089
),
9190
time_format="%Y-%m-%d",
92-
timezone="Asia/Singapore",
91+
timezone="UTC",
9392
drag_range=True,
9493
),
9594
ui.output_text("value9"),
@@ -104,7 +103,7 @@
104103
max=datetime(2023, 12, 31, 23, 59, tzinfo=TIMEZONE),
105104
value=datetime(2023, 6, 15, 12, 30, tzinfo=TIMEZONE),
106105
time_format="%Y-%m-%d %H:%M",
107-
timezone="Asia/Singapore",
106+
timezone="UTC",
108107
),
109108
ui.output_text("value10"),
110109
),

tests/playwright/shiny/tests_for_ai_generated_apps/input_slider/app-express.py

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
1-
from datetime import date, datetime
1+
from datetime import datetime
22
from zoneinfo import ZoneInfo
33

44
from shiny.express import input, render, ui
55

66
# Define a consistent timezone
7-
TIMEZONE = ZoneInfo("Asia/Singapore")
7+
TIMEZONE = ZoneInfo("UTC")
88

99
ui.page_opts(title="Slider Parameters Demo", full_width=True)
1010

@@ -42,11 +42,11 @@ def value3():
4242
ui.input_slider(
4343
"slider4",
4444
"Select a date",
45-
min=date(2023, 1, 1),
46-
max=date(2023, 12, 31),
47-
value=date(2023, 6, 15),
45+
min=datetime(2023, 1, 1, 0, 0, tzinfo=TIMEZONE),
46+
max=datetime(2023, 12, 31, 0, 0, tzinfo=TIMEZONE),
47+
value=datetime(2023, 6, 15, 12, 30, tzinfo=TIMEZONE),
4848
time_format="%Y-%m-%d",
49-
timezone="Asia/Singapore",
49+
timezone="UTC",
5050
)
5151

5252
@render.text
@@ -106,7 +106,7 @@ def value7():
106106
datetime(2023, 9, 30, 0, 0, tzinfo=TIMEZONE),
107107
),
108108
time_format="%Y-%m-%d",
109-
timezone="Asia/Singapore",
109+
timezone="UTC",
110110
drag_range=True,
111111
)
112112

@@ -124,7 +124,7 @@ def value9():
124124
max=datetime(2023, 12, 31, 23, 59, tzinfo=TIMEZONE),
125125
value=datetime(2023, 6, 15, 12, 30, tzinfo=TIMEZONE),
126126
time_format="%Y-%m-%d %H:%M",
127-
timezone="Asia/Singapore",
127+
timezone="UTC",
128128
)
129129

130130
@render.text

tests/playwright/shiny/tests_for_ai_generated_apps/input_slider/test_input_slider_core_express.py

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -41,10 +41,10 @@ def test_slider_parameters(page: Page, app: ShinyAppProc) -> None:
4141
# Test date slider
4242
slider4 = controller.InputSlider(page, "slider4")
4343
value4 = controller.OutputText(page, "value4")
44-
value4.expect_value("Value: 2023-06-15")
44+
value4.expect_value("Value: 2023-06-15 12:30:00")
4545
slider4.expect_label("Select a date")
46-
slider4.expect_min("1672560000000.0") # 2023-01-01
47-
slider4.expect_max("1704009600000.0") # 2023-12-31
46+
slider4.expect_min("1672531200000.0") # 2023-01-01
47+
slider4.expect_max("1703980800000.0") # 2023-12-31
4848
slider4.expect_value("2023-06-15")
4949

5050
# Test animated slider
@@ -82,21 +82,21 @@ def test_slider_parameters(page: Page, app: ShinyAppProc) -> None:
8282
slider9 = controller.InputSliderRange(page, "slider9")
8383
value9 = controller.OutputText(page, "value9")
8484
value9.expect_value(
85-
"Value: (datetime.datetime(2023, 2, 28, 16, 0), datetime.datetime(2023, 9, 29, 16, 0))"
85+
"Value: (datetime.datetime(2023, 3, 1, 0, 0), datetime.datetime(2023, 9, 30, 0, 0))"
8686
)
8787
slider9.expect_label("Draggable range")
88-
slider9.expect_min("1672502400000.0") # 2023-01-01
89-
slider9.expect_max("1703952000000.0") # 2023-12-31
90-
slider9.expect_value(("2023-02-28", "2023-09-29"))
88+
slider9.expect_min("1672531200000.0") # 2023-01-01
89+
slider9.expect_max("1703980800000.0") # 2023-12-31
90+
slider9.expect_value(("2023-03-01", "2023-09-30"))
9191
slider9.expect_drag_range("true")
9292

9393
# Test datetime slider
9494
slider10 = controller.InputSlider(page, "slider10")
9595
value10 = controller.OutputText(page, "value10")
96-
value10.expect_value("Value: 2023-06-15 04:30:00")
96+
value10.expect_value("Value: 2023-06-15 12:30:00")
9797
slider10.expect_label("With time format")
98-
slider10.expect_min("1672502400000.0") # 2023-01-01 00:00
99-
slider10.expect_max("1704038340000.0") # 2023-12-31 23:59
100-
slider10.expect_value("2023-06-15 04:30")
98+
slider10.expect_min("1672531200000.0") # 2023-01-01 00:00
99+
slider10.expect_max("1704067140000.0") # 2023-12-31 23:59
100+
slider10.expect_value("2023-06-15 12:30")
101101
slider10.expect_time_format("%Y-%m-%d %H:%M")
102-
slider10.expect_timezone("Asia/Singapore")
102+
slider10.expect_timezone("UTC")

0 commit comments

Comments
 (0)