install deps before running the tests

Author: karangattu

.github/workflows/pytest.yaml

@@ -199,9 +199,9 @@ jobs:
           repository: posit-dev/py-shiny-templates
           path: py-shiny-templates
 
-      - name: Copy py-shiny-templates to examples directory
+      - name: Install py-shiny-templates dependencies
         run: |
-          cp -r py-shiny-templates/* examples/
+          make install-py-shiny-templates-deps
 
       - name: Run example app tests
         timeout-minutes: 60

Makefile

@@ -220,13 +220,15 @@ ci-install-wheel: dist FORCE
 	uv pip install dist/shiny*.whl
 
 install-deps: FORCE ## install dependencies
-	pip install -e ".[dev,test]" --upgrade
+	uv pip install -e ".[dev,test]" --upgrade
 ci-install-deps: FORCE
 	uv pip install -e ".[dev,test]"
+install-py-shiny-templates-deps: FORCE
+	uv pip install -r py-shiny-templates/requirements.txt
 
 install-docs: FORCE
-	pip install -e ".[dev,test,doc]"
-	pip install https://github.com/posit-dev/py-shinylive/tarball/main
+	uv pip install -e ".[dev,test,doc]"
+	uv pip install https://github.com/posit-dev/py-shinylive/tarball/main
 ci-install-docs: FORCE
 	uv pip install -e ".[dev,test,doc]" \
 		"shinylive @ git+https://github.com/posit-dev/py-shinylive.git"

pyproject.toml

@@ -91,13 +91,6 @@ test = [
     "dask[dataframe]",
     "pyarrow",
     "pyarrow-stubs",
-    "nba_api",
-    "watchfiles",
-    "cufflinks",
-    "yfinance",
-    "shiny_validate",
-    "chatlas[anthropic]",
-    "geopy",
 
 ]
 dev = [

tests/playwright/examples/example_apps.py

@@ -98,6 +98,13 @@ def get_apps(path: str) -> typing.List[str]:
     "examples/brownian": ["Failed to acquire camera feed:"],
 }
 
+# Check for Shiny output errors, except for known exception cases
+app_allow_output_error = [
+    "shiny/api-examples/SafeException/app-express.py",
+    "shiny/api-examples/SafeException/app-core.py",
+    "examples/global_pyplot/app.py",
+]
+
 
 # Altered from `shinytest2:::app_wait_for_idle()`
 # https://github.com/rstudio/shinytest2/blob/b8fdce681597e9610fc078aa6e376134c404f3bd/R/app-driver-wait.R
@@ -254,17 +261,7 @@ def on_console_msg(msg: ConsoleMessage) -> None:
             + "* ".join(console_errors)
         )
 
-        # Check for Shiny output errors, except for known exception cases
-        excluded_apps = [
-            "shiny/api-examples/SafeException/app-express.py",
-            "shiny/api-examples/SafeException/app-core.py",
-            "examples/global_pyplot/app.py",
-        ]
-        if ex_app_path not in excluded_apps:
-            # Ensure the application is not busy
-            expect(page.locator(".shiny-busy")).to_have_count(
-                0, timeout=SHINY_INIT_TIMEOUT
-            )
+        if ex_app_path not in app_allow_output_error:
             # Ensure there are no output errors present
             error_locator = page.locator(".shiny-output-error")
             expect(error_locator).to_have_count(0, timeout=ERROR_ELEMENT_TIMEOUT)

tests/playwright/examples/test_external_templates.py

@@ -0,0 +1,17 @@
+import pytest
+from example_apps import get_apps, reruns, reruns_delay, validate_example
+from playwright.sync_api import Page
+from conftest import here_root
+from pathlib import Path
+
+if not Path(here_root / "py-shiny-templates").exists():
+    pytest.skip(
+        "./py-shiny-templates dir is not available. Skipping test.",
+        allow_module_level=True,
+    )
+@pytest.mark.only_browser("chromium")
+@pytest.mark.flaky(reruns=reruns, reruns_delay=reruns_delay)
+@pytest.mark.parametrize("ex_app_path", get_apps("py-shiny-templates"))
+def test_external_templates(page: Page, ex_app_path: str) -> None:
+
+    validate_example(page, ex_app_path)