Skip to content

Commit 997604c

Browse files
committed
Remove unneded use of $()
1 parent db4ad56 commit 997604c

File tree

5 files changed

+35
-45
lines changed

5 files changed

+35
-45
lines changed

js/chat/chat.ts

Lines changed: 17 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -527,28 +527,26 @@ customElements.define(CHAT_MESSAGES_TAG, ChatMessages);
527527
customElements.define(CHAT_INPUT_TAG, ChatInput);
528528
customElements.define(CHAT_CONTAINER_TAG, ChatContainer);
529529

530-
$(function () {
531-
window.Shiny.addCustomMessageHandler(
532-
"shinyChatMessage",
533-
function (message: ShinyChatMessage) {
534-
const evt = new CustomEvent(message.handler, {
535-
detail: message.obj,
536-
});
530+
window.Shiny.addCustomMessageHandler(
531+
"shinyChatMessage",
532+
function (message: ShinyChatMessage) {
533+
const evt = new CustomEvent(message.handler, {
534+
detail: message.obj,
535+
});
537536

538-
const el = document.getElementById(message.id);
537+
const el = document.getElementById(message.id);
539538

540-
if (!el) {
541-
showShinyClientMessage({
542-
status: "error",
543-
message: `Unable to handle Chat() message since element with id
539+
if (!el) {
540+
showShinyClientMessage({
541+
status: "error",
542+
message: `Unable to handle Chat() message since element with id
544543
${message.id} wasn't found. Do you need to call .ui() (Express) or need a
545544
chat_ui('${message.id}') in the UI (Core)?
546545
`,
547-
});
548-
return;
549-
}
550-
551-
el.dispatchEvent(evt);
546+
});
547+
return;
552548
}
553-
);
554-
});
549+
550+
el.dispatchEvent(evt);
551+
}
552+
);

js/data-frame/index.tsx

Lines changed: 10 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1214,15 +1214,13 @@ customElements.define("shiny-data-frame", ShinyDataFrameOutput);
12141214
// react listener.
12151215
// It would be better to have something similar to session.send_input_message
12161216
// for updating outputs, but that requires changes to ShinyJS.
1217-
$(function () {
1218-
window.Shiny.addCustomMessageHandler(
1219-
"shinyDataFrameMessage",
1220-
function (message) {
1221-
const evt = new CustomEvent(message.handler, {
1222-
detail: message.obj,
1223-
});
1224-
const el = document.getElementById(message.id);
1225-
el?.dispatchEvent(evt);
1226-
}
1227-
);
1228-
});
1217+
window.Shiny.addCustomMessageHandler(
1218+
"shinyDataFrameMessage",
1219+
function (message) {
1220+
const evt = new CustomEvent(message.handler, {
1221+
detail: message.obj,
1222+
});
1223+
const el = document.getElementById(message.id);
1224+
el?.dispatchEvent(evt);
1225+
}
1226+
);

js/markdown-stream/markdown-stream.ts

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -272,11 +272,9 @@ function handleMessage(message: ContentMessage | IsStreamingMessage): void {
272272
}
273273
}
274274

275-
$(function () {
276-
window.Shiny.addCustomMessageHandler(
277-
"shinyMarkdownStreamMessage",
278-
handleMessage
279-
);
280-
});
275+
window.Shiny.addCustomMessageHandler(
276+
"shinyMarkdownStreamMessage",
277+
handleMessage
278+
);
281279

282280
export { MarkdownElement, contentToHTML };

shiny/api-examples/send_custom_message/app-core.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,8 @@
88
ui.tags.div(id="messages"),
99
ui.tags.script(
1010
"""
11-
$(function() {
12-
Shiny.addCustomMessageHandler("append_msg", function(message) {
13-
$("<p>").text(message.msg).appendTo("#messages");
14-
});
11+
Shiny.addCustomMessageHandler("append_msg", function(message) {
12+
$("<p>").text(message.msg).appendTo("#messages");
1513
});
1614
"""
1715
),

shiny/api-examples/send_custom_message/app-express.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,8 @@
88
ui.tags.div(id="messages")
99
ui.tags.script(
1010
"""
11-
$(function() {
12-
Shiny.addCustomMessageHandler("append_msg", function(message) {
13-
$("<p>").text(message.msg).appendTo("#messages");
14-
});
11+
Shiny.addCustomMessageHandler("append_msg", function(message) {
12+
$("<p>").text(message.msg).appendTo("#messages");
1513
});
1614
"""
1715
)

0 commit comments

Comments
 (0)