Add more test methods

Author: karangattu

shiny/playwright/controller/_layout.py

@@ -6,6 +6,9 @@
 from playwright.sync_api import expect as playwright_expect
 
 from .._types import PatternOrStr, Timeout
+from ..expect._internal import (
+    expect_attribute_to_have_value as _expect_attribute_to_have_value,
+)
 from ..expect._internal import expect_class_to_have_value as _expect_class_to_have_value
 from ..expect._internal import expect_style_to_have_value as _expect_style_to_have_value
 from ._base import UiWithContainer, WidthLocM
@@ -131,6 +134,64 @@ def expect_bg_color(self, value: PatternOrStr, *, timeout: Timeout = None) -> No
             self.loc_container, "--_sidebar-bg", value, timeout=timeout
         )
 
+    def expect_desktop_state(
+        self, value: Literal["open", "closed", "always"], *, timeout: Timeout = None
+    ) -> None:
+        """
+        Asserts that the sidebar has the expected state on desktop.
+
+        Parameters
+        ----------
+        value
+            The expected state of the sidebar on desktop.
+        timeout
+            The maximum time to wait for the state to appear. Defaults to `None`.
+        """
+        _expect_attribute_to_have_value(
+            self.loc_container,
+            name="data-open-desktop",
+            value=value,
+            timeout=timeout,
+        )
+
+    def expect_mobile_state(
+        self, value: Literal["open", "closed", "always"], *, timeout: Timeout = None
+    ) -> None:
+        """
+        Asserts that the sidebar has the expected state on mobile.
+
+        Parameters
+        ----------
+        value
+            The expected state of the sidebar on mobile.
+        timeout
+            The maximum time to wait for the state to appear. Defaults to `None`.
+        """
+        _expect_attribute_to_have_value(
+            self.loc_container,
+            name="data-open-mobile",
+            value=value,
+            timeout=timeout,
+        )
+
+    def expect_mobile_max_height(
+        self, value: PatternOrStr, *, timeout: Timeout = None
+    ) -> None:
+        """
+        Asserts that the sidebar has the expected maximum height on mobile.
+
+        Parameters
+        ----------
+        value
+            The expected maximum height of the sidebar on mobile.
+        timeout
+            The maximum time to wait for the maximum height to appear. Defaults to `None`.
+        """
+        self.expect_mobile_state("always", timeout=timeout)
+        _expect_style_to_have_value(
+            self.loc_container, "--_mobile-max-height", value, timeout=timeout
+        )
+
     def expect_title(self, value: PatternOrStr, *, timeout: Timeout = None) -> None:
         """
         Asserts that the sidebar has the expected title.

tests/playwright/shiny/inputs/sidebar_kitchensink/app.py

@@ -10,7 +10,6 @@
             title="Left sidebar",
             bg="dodgerBlue",
             class_="text-white",
-            max_height_mobile="175px",
             gap="20px",
             padding="10px",
         ):
@@ -26,7 +25,7 @@ def state_left():
         with ui.sidebar(
             id="sidebar_right",
             position="right",
-            open="desktop",
+            open={"desktop": "closed", "mobile": "open"},
             padding=["10px", "20px"],
             bg="SlateBlue",
         ):
@@ -59,6 +58,7 @@ def state_closed():
             open="always",
             bg="PeachPuff",
             padding=["10px", "20px", "30px", "40px"],
+            max_height_mobile="175px",
         ):
             "Always sidebar content"
 

tests/playwright/shiny/inputs/sidebar_kitchensink/test_sidebar_kitchensink.py

@@ -15,6 +15,8 @@ def test_sidebar_position_and_open(page: Page, local_app: ShinyAppProc) -> None:
     left_sidebar.expect_gap("20px")
     left_sidebar.expect_class("text-white", has_class=True)
     left_sidebar.expect_bg_color("dodgerBlue")
+    left_sidebar.expect_desktop_state("open")
+    left_sidebar.expect_mobile_state("closed")
     output_txt_left.expect_value("input.sidebar_left(): True")
     left_sidebar.expect_open(True)
     left_sidebar.set(False)
@@ -28,6 +30,8 @@ def test_sidebar_position_and_open(page: Page, local_app: ShinyAppProc) -> None:
     right_sidebar = controller.Sidebar(page, "sidebar_right")
     right_sidebar.expect_padding(["10px", "20px"])
     right_sidebar.expect_bg_color("SlateBlue")
+    right_sidebar.expect_mobile_state("open")
+    right_sidebar.expect_desktop_state("closed")
 
     closed_sidebar = controller.Sidebar(page, "sidebar_closed")
     closed_sidebar.expect_padding(["10px", "20px", "30px"])
@@ -36,3 +40,7 @@ def test_sidebar_position_and_open(page: Page, local_app: ShinyAppProc) -> None:
     always_sidebar = controller.Sidebar(page, "sidebar_always")
     always_sidebar.expect_padding(["10px", "20px", "30px", "40px"])
     always_sidebar.expect_bg_color("PeachPuff")
+    always_sidebar.expect_open(True)
+    always_sidebar.expect_desktop_state("always")
+    always_sidebar.expect_mobile_state("always")
+    always_sidebar.expect_mobile_max_height("175px")