Remove controller since their isn't much of anything worth providing. Cleanup test

Author: cpsievert

shiny/playwright/controller/__init__.py

@@ -50,9 +50,6 @@
 from ._chat import (
     Chat,
 )
-from ._markdown_stream import (
-    MarkdownStream,
-)
 from ._navs import (
     NavPanel,
     NavsetBar,
@@ -107,7 +104,6 @@
     "OutputUi",
     "ValueBox",
     "Card",
-    "MarkdownStream",
     "Chat",
     "Accordion",
     "AccordionPanel",

shiny/playwright/controller/_markdown_stream.py

@@ -1,12 +1,10 @@
 from playwright.sync_api import Page, expect
-from utils.deploy_utils import skip_on_webkit
 
-from shiny.playwright import controller
 from shiny.run import ShinyAppProc
 
 
-async def is_element_scrolled_to_bottom(page: Page, selector: str) -> bool:
-    return await page.evaluate(
+def is_element_scrolled_to_bottom(page: Page, selector: str) -> bool:
+    return page.evaluate(
         """(selector) => {
         const element = document.querySelector(selector);
         if (!element) return false;
@@ -16,23 +14,24 @@ async def is_element_scrolled_to_bottom(page: Page, selector: str) -> bool:
         const scrollHeight = Math.round(element.scrollHeight);
         const clientHeight = Math.round(element.clientHeight);
 
+        // Check if the element is scrollable
+        if (scrollHeight <= clientHeight) return false;
+
         // Check if we're at the bottom (allowing for 1px difference due to rounding)
         return Math.abs((scrollTop + clientHeight) - scrollHeight) <= 1;
     }""",
         selector,
     )
 
 
-@skip_on_webkit
-async def test_validate_stream_basic(page: Page, local_app: ShinyAppProc) -> None:
+def test_validate_stream_basic(page: Page, local_app: ShinyAppProc) -> None:
     page.goto(local_app.url)
 
-    stream = controller.MarkdownStream(page, "shiny-readme")
-
-    expect(stream.loc).to_be_visible(timeout=30 * 1000)
-    stream.expect_content("pip install shiny")
+    stream = page.locator("#shiny-readme")
+    expect(stream).to_be_visible(timeout=30 * 1000)
+    expect(stream).to_contain_text("pip install shiny")
 
     # Check that the card body container (the parent of the markdown stream) is scrolled
     # all the way to the bottom
-    is_scrolled = await is_element_scrolled_to_bottom(page, ".card-body")
+    is_scrolled = is_element_scrolled_to_bottom(page, ".card-body")
     assert is_scrolled, "The card body container should be scrolled to the bottom"