Skip to content

Commit adc8eac

Browse files
committed
Follow id conventions in tests
1 parent 1686be7 commit adc8eac

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

tests/playwright/shiny/components/MarkdownStream/basic/app.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,8 @@
1010
readme_chunks = f.read().replace("\n", " \n ").split(" ")
1111

1212

13-
stream = ui.MarkdownStream("shiny-readme")
14-
stream_err = ui.MarkdownStream("shiny-readme-err")
13+
stream = ui.MarkdownStream("shiny_readme")
14+
stream_err = ui.MarkdownStream("shiny_readme_err")
1515

1616

1717
async def readme_generator():
@@ -46,7 +46,7 @@ async def _():
4646
stream_err.ui()
4747

4848

49-
basic_stream = ui.MarkdownStream("basic-stream-result")
49+
basic_stream = ui.MarkdownStream("basic_stream_result")
5050
basic_stream.ui()
5151

5252

tests/playwright/shiny/components/MarkdownStream/basic/test_stream_basic.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ def is_element_scrolled_to_bottom(page: Page, selector: str) -> bool:
2828
def test_validate_stream_basic(page: Page, local_app: ShinyAppProc) -> None:
2929
page.goto(local_app.url)
3030

31-
stream = page.locator("#shiny-readme")
31+
stream = page.locator("#shiny_readme")
3232
expect(stream).to_be_visible(timeout=30 * 1000)
3333
expect(stream).to_contain_text("pip install shiny")
3434

@@ -37,7 +37,7 @@ def test_validate_stream_basic(page: Page, local_app: ShinyAppProc) -> None:
3737
is_scrolled = is_element_scrolled_to_bottom(page, ".card-body")
3838
assert is_scrolled, "The card body container should be scrolled to the bottom"
3939

40-
stream2 = page.locator("#shiny-readme-err")
40+
stream2 = page.locator("#shiny_readme_err")
4141
expect(stream2).to_be_visible(timeout=30 * 1000)
4242
expect(stream2).to_contain_text("Shiny")
4343

0 commit comments

Comments
 (0)