Skip to content

Commit b1d0ccc

Browse files
committed
refactor: move theme method calls into helper methods
1 parent 0fe7fa1 commit b1d0ccc

File tree

1 file changed

+22
-10
lines changed

1 file changed

+22
-10
lines changed

shiny/ui/_theme_brand.py

Lines changed: 22 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -207,18 +207,12 @@ def __init__(
207207
self.add_defaults("", "// *---- brand: end of defaults ----* //", "")
208208
self._add_sass_ensure_variables()
209209
self._add_sass_brand_grays()
210-
self.add_defaults(**brand_bootstrap.defaults)
211-
self.add_defaults(
212-
"// *---- brand.defaults.bootstrap + brand.defaults.shiny.theme ----* //"
213-
)
214-
self.add_defaults(**sass_vars_typography)
215-
self.add_defaults("\n// *---- brand.typography ----* //")
216-
self.add_defaults(**sass_vars_colors)
217-
self.add_defaults("\n// *---- brand.color ----* //")
210+
self._add_defaults_brand_bootstrap(brand_bootstrap)
211+
self._add_defaults_typography(sass_vars_typography)
212+
self._add_defaults_color(sass_vars_colors)
218213

219214
# Brand rules (now in forwards order)
220-
self.add_rules("\n// *---- brand.color.palette ----*/ /")
221-
self.add_rules(":root {", *css_vars_colors, "}")
215+
self._add_rules_brand_colors(css_vars_colors)
222216
self._add_sass_brand_rules()
223217

224218
def _prepare_color_vars(self) -> tuple[dict[str, str], list[str]]:
@@ -382,6 +376,16 @@ def _add_sass_brand_grays(self):
382376
)
383377
self.add_defaults("// *---- brand: automatic gray gradient ----* //")
384378

379+
def _add_defaults_brand_bootstrap(self, brand_bootstrap: BrandBootstrap):
380+
self.add_defaults(**brand_bootstrap.defaults)
381+
self.add_defaults(
382+
"// *---- brand.defaults.bootstrap + brand.defaults.shiny.theme ----* //"
383+
)
384+
385+
def _add_defaults_typography(self, sass_vars_typography: dict[str, str]):
386+
self.add_defaults(**sass_vars_typography)
387+
self.add_defaults("\n// *---- brand.typography ----* //")
388+
385389
def _add_sass_brand_rules(self):
386390
"""Additional rules to fill in Bootstrap styles for Brand parameters"""
387391
self.add_rules(
@@ -422,6 +426,14 @@ def _add_sass_brand_rules(self):
422426
"""
423427
)
424428

429+
def _add_defaults_color(self, sass_vars_colors: dict[str, str]):
430+
self.add_defaults(**sass_vars_colors)
431+
self.add_defaults("\n// *---- brand.color ----* //")
432+
433+
def _add_rules_brand_colors(self, css_vars_colors: list[str]):
434+
self.add_rules("\n// *---- brand.color.palette ----* //")
435+
self.add_rules(":root {", *css_vars_colors, "}")
436+
425437
def _handle_unmapped_variable(self, unmapped: str):
426438
if os.environ.get("SHINY_BRAND_YML_RAISE_UNMAPPED") == "true":
427439
raise ThemeBrandUnmappedFieldError(unmapped)

0 commit comments

Comments
 (0)