Skip to content

Commit b208724

Browse files
committed
add relevant comments
1 parent 37df231 commit b208724

File tree

1 file changed

+6
-4
lines changed

1 file changed

+6
-4
lines changed

tests/playwright/examples/example_apps.py

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -254,15 +254,17 @@ def on_console_msg(msg: ConsoleMessage) -> None:
254254
+ "* ".join(console_errors)
255255
)
256256

257-
# check for shiny output errors
258-
# Skip output error checks for SafeException example apps
259-
if ex_app_path not in [
257+
# Check for Shiny output errors, except for known exception cases
258+
excluded_apps = [
260259
"shiny/api-examples/SafeException/app-express.py",
261260
"shiny/api-examples/SafeException/app-core.py",
262261
"examples/global_pyplot/app.py",
263-
]:
262+
]
263+
if ex_app_path not in excluded_apps:
264+
# Ensure the application is not busy
264265
expect(page.locator(".shiny-busy")).to_have_count(
265266
0, timeout=SHINY_INIT_TIMEOUT
266267
)
268+
# Ensure there are no output errors present
267269
error_locator = page.locator(".shiny-output-error")
268270
expect(error_locator).to_have_count(0, timeout=ERROR_ELEMENT_TIMEOUT)

0 commit comments

Comments
 (0)