Skip to content

Commit c685fe1

Browse files
committed
Updates
1 parent 131df18 commit c685fe1

File tree

4 files changed

+3
-49
lines changed

4 files changed

+3
-49
lines changed

docs/_quartodoc-express.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,7 @@ quartodoc:
126126
- express.ui.update_numeric
127127
- express.ui.update_text
128128
- express.ui.update_text_area
129-
- express.ui.update_navs
129+
- express.ui.update_navset
130130
- express.ui.update_action_button
131131
- express.ui.update_action_link
132132
- express.ui.update_task_button

shiny/api-examples/update_navs/app-core.py

Lines changed: 0 additions & 20 deletions
This file was deleted.

shiny/api-examples/update_navs/app-express.py

Lines changed: 0 additions & 18 deletions
This file was deleted.

tests/playwright/examples/example_apps.py

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -48,12 +48,6 @@ def get_apps(path: str) -> typing.List[str]:
4848
"shiny.render.transformer.output_transformer()",
4949
]
5050

51-
nav_panel_errors = [
52-
"ShinyDeprecationWarning:",
53-
"ShinyDeprecationWarning: `ShinyDeprecationWarning: `shiny.ui.update_navs()` has been superseded by `shiny.ui.update_navset()` and will be removed in the near future.",
54-
' ui.update_navs("inTabset", selected="panel2" if c_num % 2 else "panel1")',
55-
' ui.update_navs("inTabset", selected="panel" + str(input.controller()))',
56-
]
5751
express_warnings = ["Detected Shiny Express app. "]
5852
app_allow_shiny_errors: typing.Dict[
5953
str, typing.Union[Literal[True], typing.List[str]]
@@ -75,7 +69,6 @@ def get_apps(path: str) -> typing.List[str]:
7569
"examples/brownian": [*output_transformer_errors],
7670
"examples/model-score": [*output_transformer_errors],
7771
"deploys/plotly": [*output_transformer_errors],
78-
"api-examples/update_navs": [*nav_panel_errors],
7972
}
8073
app_allow_external_errors: typing.List[str] = [
8174
# TODO-garrick-future: Remove after fixing sidebar max_height_mobile warning
@@ -243,9 +236,8 @@ def on_console_msg(msg: ConsoleMessage) -> None:
243236
print("\nshort_app_path: " + short_app_path)
244237
print("\napp_allowable_errors :")
245238
print("\n".join(app_allowable_errors))
246-
print("\nError lines remaining:")
247-
print("\n".join(error_lines))
248-
print("Error lines: ", error_lines)
239+
# The below can be used to get the exact lines needed to update the `app_allow_*_errors()` objects above
240+
print("Unignored remaining lines in raw format: ", error_lines)
249241
assert len(error_lines) == 0
250242

251243
# Check for JavaScript errors

0 commit comments

Comments
 (0)