Updated tests and doc strings

Author: elnelson575

shiny/ui/_input_date.py

@@ -45,7 +45,7 @@ def input_date(
     value
         The starting date. Either a :class:`~datetime.date` object, or a string in
         `yyyy-mm-dd` format. If None (the default), will use the current date in the
-        client's time zone.
+        client's time zone. If an empty string is passed, the date picker will be blank.
     min
         The minimum allowed date. Either a :class:`~datetime.date` object, or a string in
         yyyy-mm-dd format.

shiny/ui/_input_update.py

@@ -464,7 +464,6 @@ def update_date(
         An input label.
     value
         The starting date. Either a `date()` object, or a string in yyyy-mm-dd format.
-        If ``None`` (the default), will use the current date in the client's time zone.
     min
         The minimum allowed value.
     max
@@ -475,14 +474,15 @@ def update_date(
 
     Note
     ----
-    {note}
+    You cannot update the value of a date input to `None` or an empty string.
 
     See Also
     --------
     * :func:`~shiny.ui.input_date`
     """
 
     session = require_active_session(session)
+
     msg = {
         "label": session._process_ui(label) if label is not None else None,
         "value": _as_date_attr(value),

tests/playwright/shiny/components/datepicker/app.py

@@ -1,17 +1,17 @@
-from datetime import datetime
+from datetime import date
 
 from dateutil.relativedelta import relativedelta
 
-from shiny import App, Inputs, Outputs, Session, render, ui
+from shiny import App, Inputs, Outputs, Session, reactive, render, ui
 
-min_date = datetime.fromisoformat("2011-11-04T00:05:23")
+min_date = date.fromisoformat("2011-11-04")
 max_date = min_date + relativedelta(days=10)
 
 # Our input requires strings to be in the format "YYYY-MM-DD"
 str_min = min_date.strftime("%Y-%m-%d")
 str_max = max_date.strftime("%Y-%m-%d")
 
-ui = ui.page_fluid(
+app_ui = ui.page_fluid(
     ui.input_date(
         "start_date_picker",
         "Date Type Input:",
@@ -42,15 +42,7 @@
         language="en",
     ),
     ui.output_text("str_format"),
-    ui.input_date(
-        "none_date_picker",
-        "None Type Input:",
-        value=None,
-        min=None,
-        max=None,
-        format="yyyy-mm-dd",
-        language="en",
-    ),
+    ui.input_date("none_date_picker", "None Type Input:"),
     ui.output_text("none_format"),
     ui.input_date(
         "empty_date_picker",
@@ -62,6 +54,7 @@
         language="en",
     ),
     ui.output_text("empty_format"),
+    ui.input_action_button("update", "Update Dates"),
 )
 
 
@@ -86,5 +79,15 @@ def none_format():
     def empty_format():
         return "Date Picker Value: " + str(input.empty_date_picker())
 
+    @reactive.effect
+    @reactive.event(input.update, ignore_none=True, ignore_init=True)
+    def _():
+        d = date.fromisoformat("2011-11-05")
+        ui.update_date("start_date_picker", value=d)
+        ui.update_date("str_date_picker", value="2020-01-01")
+
+    # Note: You cannot update the value of a date input to None (it will be dropped).
+    # Note: You cannot update the value of a date input to an empty string. This is a Bootstrap Datepicker limitation.
+
 
-app = App(ui, server, debug=True)
+app = App(app_ui, server, debug=True)

tests/playwright/shiny/components/datepicker/test_datepicker.py

@@ -1,8 +1,9 @@
-from playwright.sync_api import Page, expect
+import datetime
+
+from playwright.sync_api import Page
 
 from shiny.playwright import controller
 from shiny.run import ShinyAppProc
-import datetime
 
 
 def test_dynamic_navs(page: Page, local_app: ShinyAppProc) -> None:
@@ -48,3 +49,11 @@ def test_dynamic_navs(page: Page, local_app: ShinyAppProc) -> None:
 
     date_output5 = controller.OutputText(page, "empty_format")
     date_output5.expect_value("Date Picker Value: None")
+
+    controller.InputActionButton(page, "update").click()
+
+    date1.expect_value("05.11.2011")
+    date_output.expect_value("Date Picker Value: 2011-11-05")
+
+    date3.expect_value("01-01-2020")
+    date_output3.expect_value("Date Picker Value: 2020-01-01")