fix: errors on bookmark are now surfaced in the Python console

Author: cpsievert

shiny/bookmark/_bookmark.py

@@ -558,15 +558,10 @@ async def do_bookmark(self) -> None:
                     await self.show_bookmark_url_modal(full_url)
 
         except Exception as e:
-            msg = f"Error bookmarking state: {e}"
-            from ..ui._notification import notification_show
-
-            notification_show(
-                msg,
-                duration=None,
-                type="error",
-                session=self._root_session,
-            )
+            from ..types import NotifyException
+
+            msg = f"Error bookmarking state: {str(e)}"
+            raise NotifyException(msg) from e
 
 
 class BookmarkProxy(Bookmark):

shiny/reactive/_reactives.py

@@ -597,9 +597,10 @@ async def _run(self) -> None:
                     from ..ui import notification_show
 
                     msg = str(e)
+                    warnings.warn(msg, ReactiveWarning, stacklevel=2)
                     if e.sanitize:
                         msg = SANITIZE_ERROR_MSG
-                    notification_show(msg, type="error", duration=5000)
+                    notification_show(msg, type="error", duration=None)
                     if e.close:
                         await self._session._unhandled_error(e)
             except Exception as e: