Add bookmark workaround for on_restored() callbacks not executing on load #1889

Author: schloerke

shiny/bookmark/_bookmark.py

@@ -363,10 +363,7 @@ async def invoke_on_restore_callbacks():
 
             # Run the on_restored function after the flush cycle completes and
             # information is sent to the client.
-            # Update: Using `on_flush` to have the callbacks populate the output message
-            # queue going to the browser. If `on_flushed` is used, the messages stall
-            # until the next `on_flushed` invocation.
-            @session.on_flush
+            @session.on_flushed
             async def invoke_on_restored_callbacks():
                 if self._on_restored_callbacks.count() == 0:
                     return

shiny/session/_session.py

@@ -664,6 +664,11 @@ def verify_state(expected_state: ConnectionState) -> None:
                             with session_context(self):
                                 self.app.server(self.input, self.output, self)
 
+                            # TODO: Remove this call to reactive_flush() once https://github.com/posit-dev/py-shiny/issues/1889 is fixed
+                            # Workaround: Any `on_flushed()` calls from bookmark's `on_restored()` will be flushed here
+                            if self.bookmark.store != "disable":
+                                await reactive_flush()
+
                         elif message_obj["method"] == "update":
                             verify_state(ConnectionState.Running)