Remove the headache of modin

Author: schloerke

pyproject.toml

@@ -87,10 +87,6 @@ test = [
     "faicons",
     "ridgeplot",
     "great_tables",
-    # modin depends on ray, which doesn't support Python 3.13
-    "modin[all];python_version<'3.13'",
-    # ray doesn't currently support Python 3.13
-    "ray;python_version<'3.13'",
     "polars",
     "dask[dataframe]",
     "pyarrow",

tests/playwright/shiny/components/data_frame/data_type/app.py

@@ -1,13 +1,5 @@
 from __future__ import annotations
 
-import sys
-
-# Remove this conditional once modin is supported on Python 3.13
-if sys.version_info < (3, 13):
-    import modin.pandas as mpd  # pyright: ignore[reportMissingTypeStubs]
-else:
-    raise RuntimeError("This test is not supported on Python 3.13")
-
 import narwhals.stable.v1 as nw
 import palmerpenguins  # pyright: ignore[reportMissingTypeStubs]
 import polars as pl
@@ -19,7 +11,6 @@
 
 nw_df = nw.from_native(pd_df, eager_only=True)
 pa_df = pa.table(pd_df)  # pyright: ignore[reportUnknownMemberType]
-mpd_df = mpd.DataFrame(pd_df)
 pl_df = pl.DataFrame(pd_df)
 
 
@@ -145,46 +136,6 @@ def pa_data_view():
         def pa_data_view_selected():
             return str(type(pa_df_original.data_view(selected=True)))
 
-    with ui.card():
-        ui.h2("Modin Data")
-
-        @render.data_frame
-        def mpd_df_original():
-            return render.DataGrid(
-                data=mpd_df,
-                selection_mode="row",
-            )
-
-        "Selected row:"
-
-        @render.data_frame
-        def selected_mpd_row():
-            return mpd_df_original.data_view(selected=True)
-
-        "Data type:"
-
-        @render.code
-        def mpd_type():
-            return str(type(mpd_df))
-
-        ui.markdown("`.data()` type:")
-
-        @render.code
-        def mpd_data():
-            return str(type(mpd_df_original.data()))
-
-        ui.markdown("`.data_view()` type:")
-
-        @render.code
-        def mpd_data_view():
-            return str(type(mpd_df_original.data_view()))
-
-        ui.markdown("`.data_view(selected=True)` type:")
-
-        @render.code
-        def mpd_data_view_selected():
-            return str(type(mpd_df_original.data_view(selected=True)))
-
     with ui.card():
         ui.h2("Polars Data")
 

tests/playwright/shiny/components/data_frame/data_type/test_df_data_type.py

@@ -1,7 +1,5 @@
 import re
-import sys
 
-import pytest
 from playwright.sync_api import Page
 
 from shiny.playwright import controller
@@ -32,19 +30,9 @@
         "df_original": "pl_df_original",
         "selected_row": "selected_pl_row",
     },
-    {
-        "name": "modin",
-        "prefix": "mpd",
-        "df_original": "mpd_df_original",
-        "selected_row": "selected_mpd_row",
-    },
 ]
 
 
-@pytest.mark.skipif(
-    sys.version_info[:2] == (3, 13),
-    reason="Skipping on Python 3.13, since modin is not supported on 3.13",
-)
 def test_data_frame_data_type(
     page: Page,
     local_app: ShinyAppProc,

tests/playwright/shiny/components/table/app.py

@@ -1,13 +1,5 @@
 from __future__ import annotations
 
-import sys
-
-# Remove this conditional once modin is supported on Python 3.13
-if sys.version_info < (3, 13):
-    import modin.pandas as md  # pyright: ignore[reportMissingTypeStubs]
-else:
-    # This block executes for Python 3.13 and above
-    raise RuntimeError("This test is not supported on Python 3.13")
 import narwhals.stable.v1 as nw
 import palmerpenguins  # pyright: ignore[reportMissingTypeStubs]
 
@@ -17,8 +9,6 @@
 
 nw_df = nw.from_native(pd_df, eager_only=True)
 
-md_df = md.DataFrame(pd_df)
-
 with ui.card():
 
     ui.h2("Polars Pandas Data")
@@ -36,14 +26,14 @@ def nw_df_type():
 
 with ui.card():
 
-    ui.h2("Modin dataframe Data")
+    ui.h2("Pandas dataframe Data")
 
     @render.table
-    def md_table():
-        return md_df
+    def pd_table():
+        return pd_df
 
     "Data type:"
 
     @render.code
-    def md_df_type():
-        return str(type(md_df))
+    def pd_df_type():
+        return str(type(pd_df))

tests/playwright/shiny/components/table/test_table.py

@@ -1,22 +1,16 @@
 import re
-import sys
 
-import pytest
 from playwright.sync_api import Page
 
 from shiny.playwright import controller
 from shiny.run import ShinyAppProc
 
 
-@pytest.mark.skipif(
-    sys.version_info >= (3, 13),
-    reason="Skipping on Python 3.13 and above, since modin is not supported on these versions",
-)
 def test_table_data_support(page: Page, local_app: ShinyAppProc) -> None:
     page.goto(local_app.url)
 
     controller.OutputTable(page, "nw_table").expect_nrow(2)
     controller.OutputCode(page, "nw_df_type").expect_value(re.compile("narwhals"))
 
-    controller.OutputTable(page, "md_table").expect_nrow(2)
-    controller.OutputCode(page, "md_df_type").expect_value(re.compile("modin"))
+    controller.OutputTable(page, "pd_table").expect_nrow(2)
+    controller.OutputCode(page, "pd_df_type").expect_value(re.compile("pandas"))