Add bookmarking capabilities for sidebar and accordion

Author: karangattu

shiny/ui/_accordion.py

@@ -4,6 +4,8 @@
 
 from htmltools import Tag, TagAttrs, TagAttrValue, TagChild, css, tags
 
+from shiny.bookmark._restore_state import restore_input
+
 from .._docstring import add_example
 from .._namespaces import resolve_id_or_none
 from .._utils import drop_none, private_random_id
@@ -274,7 +276,7 @@ def accordion(
     for panel, open in zip(panels, is_open):
         panel._accordion_id = accordion_id
         panel._is_multiple = multiple
-        panel._is_open = open
+        panel._is_open = restore_input(accordion_id, open)
 
     panel_tags = [panel.resolve() for panel in panels]
 

shiny/ui/_sidebar.py

@@ -16,6 +16,8 @@
     tags,
 )
 
+from shiny.bookmark._restore_state import restore_input
+
 from .._docstring import add_example, no_example
 from .._namespaces import resolve_id_or_none
 from .._typing_extensions import TypedDict
@@ -545,13 +547,15 @@ def sidebar(
 
     attrs, children = consolidate_attrs(*args, **kwargs)
 
+    resolved_id = resolve_id_or_none(id)
+
     return Sidebar(
         children=children,
         attrs=attrs,
         width=width,
         position=position,
-        open=open,
-        id=id,
+        open=restore_input(resolved_id, open),
+        id=resolved_id,
         title=title,
         fg=fg,
         bg=bg,

tests/playwright/ai_generated_apps/bookmark/accordion/app-express.py

@@ -0,0 +1,41 @@
+from shiny.express import app_opts, expressify, input, module, render, session, ui
+
+app_opts(bookmark_store="url")
+
+
+@expressify
+def my_accordion(**kwargs):
+    with ui.accordion(**kwargs):
+        for letter in "ABCDE":
+            with ui.accordion_panel(f"Section {letter}"):
+                f"Some narrative for section {letter}"
+
+
+ui.h2("Accordion with bookmarking")
+
+with ui.card():
+    ui.h3("Accordion non-module bookmarking")
+    my_accordion(multiple=False, id="acc_single")
+
+    @render.text
+    def accordion_global():
+        return f"input.accordion(): {input.acc_single()}"
+
+    # Module section in sidebar
+    @module
+    def accordion_module(input, output, session):
+        my_accordion(multiple=False, id="acc_mod")
+
+        @render.text
+        def accordion_module():
+            return f"input.acc_mod(): {input.acc_mod()}"
+
+    ui.h3("Accordion module bookmarking")
+    accordion_module("first")
+
+    ui.input_bookmark_button()
+
+
+@session.bookmark.on_bookmarked
+async def _(url: str):
+    await session.bookmark.update_query_string(url)

tests/playwright/ai_generated_apps/bookmark/sidebar/app-express.py

@@ -0,0 +1,34 @@
+from shiny.express import app_opts, input, module, render, session, ui
+
+app_opts(bookmark_store="url")
+
+with ui.card():
+    with ui.layout_sidebar():
+        with ui.sidebar(id="sidebar_left", open="open", bg="#f74f7a"):
+            "Left sidebar content"
+
+        @render.text
+        def state_left():
+            return f"input.sidebar_left(): {input.sidebar_left()}"
+
+    # Module section in sidebar
+    @module
+    def sidebar_module(input, output, session):
+        with ui.layout_sidebar():
+            with ui.sidebar(
+                id="sidebar_right", position="right", open="open", bg="#4fa3f7"
+            ):
+                "Right sidebar content"
+
+            @render.text
+            def state_right():
+                return f"input.sidebar_right(): {input.sidebar_right()}"
+
+    sidebar_module("first")
+
+    ui.input_bookmark_button()
+
+
+@session.bookmark.on_bookmarked
+async def _(url: str):
+    await session.bookmark.update_query_string(url)