adding ignore to pyright errors within apps

Author: karangattu

Makefile

@@ -74,11 +74,7 @@ typings/matplotlib/__init__.pyi:
 	git clone --depth 1 https://github.com/microsoft/python-type-stubs typings/python-type-stubs
 	mv typings/python-type-stubs/stubs/matplotlib typings/
 	rm -rf typings/python-type-stubs
-typings/plotly:
-	@echo "Creating plotly stubs"
-	pyright --createstub plotly
-
-pyright-typings: typings/appdirs typings/folium typings/uvicorn typings/seaborn typings/plotly typings/matplotlib/__init__.pyi
+pyright-typings: typings/appdirs typings/folium typings/uvicorn typings/seaborn typings/matplotlib/__init__.pyi
 
 check: check-format check-lint check-types check-tests  ## check code, style, types, and test (basic CI)
 check-fix: format check-lint check-types check-tests ## check and format code, style, types, and test

tests/playwright/shiny/components/chat/shiny_output/app.py

@@ -1,7 +1,6 @@
 import ipyleaflet as ipyl  # pyright: ignore[reportMissingTypeStubs]
 import pandas as pd
 import plotly.express as px  # pyright: ignore[reportMissingTypeStubs]
-from plotly.graph_objs._figure import Figure
 from shinywidgets import render_plotly, render_widget
 
 from shiny import reactive, render
@@ -56,9 +55,11 @@ async def _():
 with ui.hold() as plot_ui:
 
     @render_plotly
-    def plot() -> Figure:
+    def plot():  # pyright: ignore[reportUnknownReturnType,reportUnknownParameterType]
         dat = pd.DataFrame({"x": [1, 2, 3], "y": [4, 5, 6]})
-        return px.scatter(dat, x="x", y="y")  # pyright: ignore[reportUnknownMemberType]
+        return px.scatter(  # pyright: ignore[reportUnknownMemberType,reportUnknownVariableType]
+            dat, x="x", y="y"
+        )
 
 
 @reactive.effect

tests/playwright/shiny/components/data_frame/edit/app.py

@@ -17,7 +17,6 @@
 import great_tables as gt
 import palmerpenguins  # pyright: ignore[reportMissingTypeStubs]
 import polars as pl
-from plotly.graph_objs._figure import Figure
 
 from shiny import App, Inputs, Outputs, Session, module, reactive, render, req, ui
 from shiny.render import CellPatch
@@ -262,22 +261,19 @@ def df_styles_fn(data: pd.DataFrame) -> list[StyleInfo]:
     #     print(summary_data._type_hints())
     from shinywidgets import render_widget
 
-    # from shiny import reactive
-
     @render_widget
-    def country_detail_pop() -> Figure:
+    def country_detail_pop():  # pyright: ignore[reportUnknownParameterType]
         import plotly.express as px
 
-        fig: Figure = px.line(
-            px.data.gapminder(),
+        # Create the figure explicitly
+        return px.line(
+            px.data.gapminder(),  # pyright: ignore[reportUnknownVariableType,reportAttributeAccessIssue]
             x="year",
             y="lifeExp",
             color="country",
             title="Population Over Time",
         )
 
-        return fig
-
     @summary_data.set_patch_fn
     def upgrade_patch(
         *,

tests/playwright/shiny/components/data_frame/html_columns/app.py

@@ -33,10 +33,10 @@ def random_generator():
     )
 )
 
-studyName = (
-    pd_penguins["studyName"]  # pyright: ignore[reportUnknownVariableType]
+studyName = (  # pyright: ignore[reportUnknownVariableType]
+    pd_penguins["studyName"]
     .copy()
-    .astype("object")
+    .astype("object")  # pyright: ignore[reportUnknownMemberType]
 )
 # Set the first value of the column to an html object so the column is treated as object by narwhals (not str)
 studyName[0] = htmlDep