`@render.download` in Express modules

[julibeg]

Related to #1724 and #1726 but in Express.

@express.render.download() doesn't accept an id argument and also doesn't include the parent module's ns in the download link. Therefore, all download buttons created with an Express module download the same file. Consider the MWE below

from shiny.express import module, render, ui


@module
def card_with_download(input, output, session, label):
    with ui.card():
        ui.card_header(f"download {label}")

        @render.download(filename=f"test-{label}.txt", label=f"Download {label}")
        def download():
            yield f"Hi, we're in {label} file\n"


labels = list("ABCD")

for i, label in enumerate(labels):
    card_with_download(f"download_{label}", label=label)

Each of the buttons will download test-D.txt.

[gadenbuie]

Thanks for the report and for the very clear example. Can you check which version of Shiny you are using? You'll need to be using shiny v1.2.0 or later, which include the fixes mentioned and where your MWE seems to work. Here's a link to your example on shinylive.io where the downloads work as expected and shiny 1.2.0 is used.

[julibeg]

Ah indeed! My bad, sorry! Upgrading to 1.2.1 fixed the issue. Thanks for the swift reply and many apologies!

[gadenbuie]

No worries @julibeg, glad we figured it out 😄