fix(controllers): Add missing expect_max_height method for value box controllers #1816
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! |
schloerke
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new method to check the maximum height of a value box and updates the corresponding tests to use this new method.
New Method Addition:
shiny/playwright/controller/_card.py: Addedexpect_max_heightmethod to check the maximum height of a value box.Test Updates:
tests/playwright/shiny/components/value_box/kitchensink/test_valuebox_ks.py: Updated the test to use the newexpect_max_heightmethod instead ofexpect_height.tests/playwright/shiny/components/value_box/smoke/test_valuebox.py: Updated the test to include bothexpect_max_heightandexpect_heightmethods.