Skip to content

Bind the correct this context to chat's callback methods passed down to <markdown-stream> #1866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 24, 2025
Merged

Bind the correct this context to chat's callback methods passed down to <markdown-stream> #1866

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3dc26bd
Bind the correct this context to chat's callback methods passed down …
cpsievert Feb 24, 2025
2000fc9
Merge branch 'main' into fix/chat-content-change-handler
cpsievert Feb 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions js/chat/chat.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,8 @@ class ChatMessage extends LightElement {
content-type=${this.content_type}
?streaming=${this.streaming}
auto-scroll
.onContentChange=${this.#onContentChange}
.onStreamEnd=${this.#makeSuggestionsAccessible}
.onContentChange=${this.#onContentChange.bind(this)}
.onStreamEnd=${this.#makeSuggestionsAccessible.bind(this)}
></shiny-markdown-stream>
`;
}
Expand Down Expand Up @@ -262,7 +262,6 @@ class ChatInput extends LightElement {
}

class ChatContainer extends LightElement {

private get input(): ChatInput {
return this.querySelector(CHAT_INPUT_TAG) as ChatInput;
}
Expand Down
4 changes: 2 additions & 2 deletions shiny/www/py-shiny/chat/chat.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions shiny/www/py-shiny/chat/chat.js.map
View file
Open in desktop

Large diffs are not rendered by default.

Loading