chore: Use shiny.module to import reexported values from shiny._namespaces
#1898
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…`, `current_namespace()`, and `ResolvedId` Related: #1896
There was a problem hiding this comment.
Pull Request Overview
This PR updates import statements to use the new reexported values from shiny.module instead of shiny._namespaces, improving code clarity and consistency. Key changes include:
- Replacing imports of resolve_id, ResolvedId, and other namespace utilities from _namespaces with the corresponding entities from module.
- Updating multiple files across the shiny codebase including UI components, session handling, and rendering.
Reviewed Changes
Copilot reviewed 28 out of 28 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| shiny/express/_stub_session.py | Updated ResolvedId import to use shiny.module |
| shiny/ui/_download_button.py | Replaced resolve_id import to use shiny.module |
| shiny/ui/_input_dark_mode.py | Replaced resolve_id import to use shiny.module |
| shiny/ui/_input_password.py | Replaced resolve_id import to use shiny.module |
| shiny/ui/_chat.py | Combined ResolvedId and resolve_id imports from module |
| shiny/ui/_input_numeric.py | Replaced resolve_id import to use shiny.module |
| shiny/ui/_input_file.py | Replaced resolve_id import to use shiny.module |
| shiny/ui/_markdown_stream.py | Replaced resolve_id import to use shiny.module |
| shiny/session/_session.py | Updated ResolvedId import to use shiny.module |
| shiny/render/_render.py | Updated ResolvedId import to use shiny.module |
| shiny/ui/_input_slider.py | Replaced resolve_id import to use shiny.module |
| shiny/ui/_input_date.py | Replaced resolve_id import to use shiny.module |
| shiny/ui/_input_check_radio.py | Replaced resolve_id import to use shiny.module |
| shiny/ui/_input_select.py | Replaced resolve_id import to use shiny.module |
| shiny/ui/_input_text.py | Replaced resolve_id import to use shiny.module |
| shiny/ui/_input_update.py | Combined ResolvedId and resolve_id imports from module |
| shiny/ui/_input_task_button.py | Replaced resolve_id import to use shiny.module |
| shiny/ui/_output.py | Replaced resolve_id import to use shiny.module |
| shiny/session/_utils.py | Updated namespace_context import to use shiny.module |
| shiny/ui/_input_action_button.py | Replaced resolve_id import to use shiny.module |
schloerke
added a commit
that referenced
this pull request
Mar 11, 2025
* main: chore: Use details for extra info from error message (#1903) ci: adds action to lint conventional commits (#1902) build: JS build script updates (#1894) chore: Rename temp environ names (for launching browser) to avoid conflict with local environ names (#1899) build: Update shiny TS types to Shiny 1.10.0 (#1893) chore: Use `shiny.module` to import re-exported values from `shiny._namespaces` (#1898)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated:
shiny._namespaces_.resolve_id()->shiny.module.resolve_id()shiny._namespaces_.current_namespace()->shiny.module.current_namespace()shiny._namespaces_.ResolvedId->shiny.module.ResolvedIdRelated: #1896