chore: Rename temp environ names to avoid conflict with local names #1899
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ex: `SHINY_PORT` is set by hosted environments and is inspected to determine if an app is being hosted. https://github.com/rstudio/shiny/blob/f55c26af4a0493b082d2967aca6d36b90795adf1/R/server.R#L510-L514
There was a problem hiding this comment.
Pull Request Overview
This PR renames temporary environment variable names to avoid conflicts with local variable names used in hosted environments.
- Renames SHINY_HOST and SHINY_PORT to SHINY_BROWSER_HOST and SHINY_BROWSER_PORT in the run_app function.
- Updates the corresponding environment variable references in the browser launch logic to reflect the new naming.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| shiny/_main.py | Renamed environment variable names to avoid conflict |
| shiny/_launchbrowser.py | Updated references and error messages with new names |
schloerke
added a commit
that referenced
this pull request
Mar 11, 2025
* main: chore: Use details for extra info from error message (#1903) ci: adds action to lint conventional commits (#1902) build: JS build script updates (#1894) chore: Rename temp environ names (for launching browser) to avoid conflict with local environ names (#1899) build: Update shiny TS types to Shiny 1.10.0 (#1893) chore: Use `shiny.module` to import re-exported values from `shiny._namespaces` (#1898)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ex:
SHINY_PORTis set by hosted environments and is inspected to determine if an app is being hosted.Related: https://github.com/rstudio/shiny/blob/f55c26af4a0493b082d2967aca6d36b90795adf1/R/server.R#L510-L514
Useful for bookmarking to determine it's own
inShinyServer()method