From 359900c62238febaf9ffe35f6761d3cf100a22ba Mon Sep 17 00:00:00 2001 From: Karan Gathani Date: Mon, 7 Apr 2025 20:40:54 -0700 Subject: [PATCH 1/3] Add retries to flaky test --- .../shiny/bookmark/chat/client_state/test_bookmark_chat.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/playwright/shiny/bookmark/chat/client_state/test_bookmark_chat.py b/tests/playwright/shiny/bookmark/chat/client_state/test_bookmark_chat.py index 3bb20459f..2ec1ab9dc 100644 --- a/tests/playwright/shiny/bookmark/chat/client_state/test_bookmark_chat.py +++ b/tests/playwright/shiny/bookmark/chat/client_state/test_bookmark_chat.py @@ -1,12 +1,14 @@ import re +import pytest from playwright.sync_api import Page from shiny.playwright.controller import Chat from shiny.run import ShinyAppProc -def test_bookmark_chatlas(page: Page, local_app: ShinyAppProc): +@pytest.mark.flaky(reruns=3, reruns_delay=1) +def test_bookmark_chat(page: Page, local_app: ShinyAppProc): page.goto(local_app.url) From 53421e034e89db8a124a573f960608913b39fd64 Mon Sep 17 00:00:00 2001 From: Karan Gathani Date: Mon, 7 Apr 2025 21:03:59 -0700 Subject: [PATCH 2/3] Bump from 3 -> 5 --- .../shiny/bookmark/chat/client_state/test_bookmark_chat.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/playwright/shiny/bookmark/chat/client_state/test_bookmark_chat.py b/tests/playwright/shiny/bookmark/chat/client_state/test_bookmark_chat.py index 2ec1ab9dc..7a501a2f8 100644 --- a/tests/playwright/shiny/bookmark/chat/client_state/test_bookmark_chat.py +++ b/tests/playwright/shiny/bookmark/chat/client_state/test_bookmark_chat.py @@ -6,8 +6,8 @@ from shiny.playwright.controller import Chat from shiny.run import ShinyAppProc - -@pytest.mark.flaky(reruns=3, reruns_delay=1) +# Up to 5 retries for intermittent WebKit timing issues +@pytest.mark.flaky(reruns=5, reruns_delay=1) def test_bookmark_chat(page: Page, local_app: ShinyAppProc): page.goto(local_app.url) From 5b92d6688cd67a4b21e012e1c98e8c27ce50468b Mon Sep 17 00:00:00 2001 From: Karan Gathani Date: Mon, 7 Apr 2025 21:10:31 -0700 Subject: [PATCH 3/3] Update test_bookmark_chat.py --- .../shiny/bookmark/chat/client_state/test_bookmark_chat.py | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/playwright/shiny/bookmark/chat/client_state/test_bookmark_chat.py b/tests/playwright/shiny/bookmark/chat/client_state/test_bookmark_chat.py index 7a501a2f8..c7debd5a7 100644 --- a/tests/playwright/shiny/bookmark/chat/client_state/test_bookmark_chat.py +++ b/tests/playwright/shiny/bookmark/chat/client_state/test_bookmark_chat.py @@ -6,6 +6,7 @@ from shiny.playwright.controller import Chat from shiny.run import ShinyAppProc + # Up to 5 retries for intermittent WebKit timing issues @pytest.mark.flaky(reruns=5, reruns_delay=1) def test_bookmark_chat(page: Page, local_app: ShinyAppProc):