From 6cbca78388d40d1a70c7f437c80e262abe172b93 Mon Sep 17 00:00:00 2001 From: Liz Nelson Date: Wed, 4 Jun 2025 14:25:36 -0400 Subject: [PATCH 1/5] Expanding timeout test --- .../components/MarkdownStream/basic/test_stream_basic.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/playwright/shiny/components/MarkdownStream/basic/test_stream_basic.py b/tests/playwright/shiny/components/MarkdownStream/basic/test_stream_basic.py index 1916e4619..a78a9b396 100644 --- a/tests/playwright/shiny/components/MarkdownStream/basic/test_stream_basic.py +++ b/tests/playwright/shiny/components/MarkdownStream/basic/test_stream_basic.py @@ -29,7 +29,7 @@ def test_validate_stream_basic(page: Page, local_app: ShinyAppProc) -> None: page.goto(local_app.url) stream = page.locator("#shiny_readme") - expect(stream).to_be_visible(timeout=30 * 1000) + expect(stream).to_be_visible(timeout=30 * 10000) expect(stream).to_contain_text("pip install shiny") # Check that the card body container (the parent of the markdown stream) is scrolled @@ -38,11 +38,11 @@ def test_validate_stream_basic(page: Page, local_app: ShinyAppProc) -> None: assert is_scrolled, "The card body container should be scrolled to the bottom" stream2 = page.locator("#shiny_readme_err") - expect(stream2).to_be_visible(timeout=30 * 1000) + expect(stream2).to_be_visible(timeout=30 * 10000) expect(stream2).to_contain_text("Shiny") notification = page.locator(".shiny-notification-error") - expect(notification).to_be_visible(timeout=30 * 1000) + expect(notification).to_be_visible(timeout=30 * 10000) expect(notification).to_contain_text("boom!") txt_result = controller.OutputText(page, "stream_result") From dea85c8bf2247370daacd775e485e609fa7e0cf8 Mon Sep 17 00:00:00 2001 From: Liz Nelson Date: Wed, 4 Jun 2025 14:54:10 -0400 Subject: [PATCH 2/5] Making the timeout even longer --- .../components/MarkdownStream/basic/test_stream_basic.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/playwright/shiny/components/MarkdownStream/basic/test_stream_basic.py b/tests/playwright/shiny/components/MarkdownStream/basic/test_stream_basic.py index a78a9b396..85ca93458 100644 --- a/tests/playwright/shiny/components/MarkdownStream/basic/test_stream_basic.py +++ b/tests/playwright/shiny/components/MarkdownStream/basic/test_stream_basic.py @@ -29,7 +29,7 @@ def test_validate_stream_basic(page: Page, local_app: ShinyAppProc) -> None: page.goto(local_app.url) stream = page.locator("#shiny_readme") - expect(stream).to_be_visible(timeout=30 * 10000) + expect(stream).to_be_visible(timeout=30 * 100000) expect(stream).to_contain_text("pip install shiny") # Check that the card body container (the parent of the markdown stream) is scrolled @@ -38,11 +38,11 @@ def test_validate_stream_basic(page: Page, local_app: ShinyAppProc) -> None: assert is_scrolled, "The card body container should be scrolled to the bottom" stream2 = page.locator("#shiny_readme_err") - expect(stream2).to_be_visible(timeout=30 * 10000) + expect(stream2).to_be_visible(timeout=30 * 100000) expect(stream2).to_contain_text("Shiny") notification = page.locator(".shiny-notification-error") - expect(notification).to_be_visible(timeout=30 * 10000) + expect(notification).to_be_visible(timeout=30 * 100000) expect(notification).to_contain_text("boom!") txt_result = controller.OutputText(page, "stream_result") From 7e108cd49580e9d864d0ca41e8ba9ce83ef862c3 Mon Sep 17 00:00:00 2001 From: Liz Nelson Date: Wed, 4 Jun 2025 15:07:07 -0400 Subject: [PATCH 3/5] Adding even more time --- .../shiny/components/MarkdownStream/basic/test_stream_basic.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/playwright/shiny/components/MarkdownStream/basic/test_stream_basic.py b/tests/playwright/shiny/components/MarkdownStream/basic/test_stream_basic.py index 85ca93458..71e5c531e 100644 --- a/tests/playwright/shiny/components/MarkdownStream/basic/test_stream_basic.py +++ b/tests/playwright/shiny/components/MarkdownStream/basic/test_stream_basic.py @@ -29,7 +29,7 @@ def test_validate_stream_basic(page: Page, local_app: ShinyAppProc) -> None: page.goto(local_app.url) stream = page.locator("#shiny_readme") - expect(stream).to_be_visible(timeout=30 * 100000) + expect(stream).to_be_visible(timeout=30 * 1000000) expect(stream).to_contain_text("pip install shiny") # Check that the card body container (the parent of the markdown stream) is scrolled From 6206ae0bf35f0df69422ccc6749c00ca1a701bdc Mon Sep 17 00:00:00 2001 From: Liz Nelson Date: Wed, 4 Jun 2025 15:17:33 -0400 Subject: [PATCH 4/5] Updating timeout --- .../MarkdownStream/basic/test_stream_basic.py | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/tests/playwright/shiny/components/MarkdownStream/basic/test_stream_basic.py b/tests/playwright/shiny/components/MarkdownStream/basic/test_stream_basic.py index 71e5c531e..183af2323 100644 --- a/tests/playwright/shiny/components/MarkdownStream/basic/test_stream_basic.py +++ b/tests/playwright/shiny/components/MarkdownStream/basic/test_stream_basic.py @@ -29,8 +29,8 @@ def test_validate_stream_basic(page: Page, local_app: ShinyAppProc) -> None: page.goto(local_app.url) stream = page.locator("#shiny_readme") - expect(stream).to_be_visible(timeout=30 * 1000000) - expect(stream).to_contain_text("pip install shiny") + expect(stream).to_be_visible(timeout=30_000) + expect(stream).to_contain_text("pip install shiny", timeout=30) # Check that the card body container (the parent of the markdown stream) is scrolled # all the way to the bottom @@ -38,12 +38,12 @@ def test_validate_stream_basic(page: Page, local_app: ShinyAppProc) -> None: assert is_scrolled, "The card body container should be scrolled to the bottom" stream2 = page.locator("#shiny_readme_err") - expect(stream2).to_be_visible(timeout=30 * 100000) - expect(stream2).to_contain_text("Shiny") + expect(stream2).to_be_visible(timeout=30_000) + expect(stream2).to_contain_text("Shiny", timeout=30) notification = page.locator(".shiny-notification-error") - expect(notification).to_be_visible(timeout=30 * 100000) - expect(notification).to_contain_text("boom!") + expect(notification).to_be_visible(timeout=30_000) + expect(notification).to_contain_text("boom!", timeout=30) txt_result = controller.OutputText(page, "stream_result") txt_result.expect_value("Stream result: Basic stream") From 852606f61197156e282c868c7f46500471e68da4 Mon Sep 17 00:00:00 2001 From: Liz Nelson Date: Wed, 4 Jun 2025 15:19:20 -0400 Subject: [PATCH 5/5] Adjust timing --- .../components/MarkdownStream/basic/test_stream_basic.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/playwright/shiny/components/MarkdownStream/basic/test_stream_basic.py b/tests/playwright/shiny/components/MarkdownStream/basic/test_stream_basic.py index 183af2323..694df7360 100644 --- a/tests/playwright/shiny/components/MarkdownStream/basic/test_stream_basic.py +++ b/tests/playwright/shiny/components/MarkdownStream/basic/test_stream_basic.py @@ -30,7 +30,7 @@ def test_validate_stream_basic(page: Page, local_app: ShinyAppProc) -> None: stream = page.locator("#shiny_readme") expect(stream).to_be_visible(timeout=30_000) - expect(stream).to_contain_text("pip install shiny", timeout=30) + expect(stream).to_contain_text("pip install shiny", timeout=30_000) # Check that the card body container (the parent of the markdown stream) is scrolled # all the way to the bottom @@ -39,11 +39,11 @@ def test_validate_stream_basic(page: Page, local_app: ShinyAppProc) -> None: stream2 = page.locator("#shiny_readme_err") expect(stream2).to_be_visible(timeout=30_000) - expect(stream2).to_contain_text("Shiny", timeout=30) + expect(stream2).to_contain_text("Shiny", timeout=30_000) notification = page.locator(".shiny-notification-error") expect(notification).to_be_visible(timeout=30_000) - expect(notification).to_contain_text("boom!", timeout=30) + expect(notification).to_contain_text("boom!", timeout=30_000) txt_result = controller.OutputText(page, "stream_result") txt_result.expect_value("Stream result: Basic stream")