From 0ca884efada56b82cef542e3dc4fabfdeac8e492 Mon Sep 17 00:00:00 2001 From: Karan Gathani Date: Thu, 11 Sep 2025 08:46:49 -0700 Subject: [PATCH 1/4] Update GitHub shiny and htmltools versions in CI Bump shiny to v1.4.0 and htmltools to v0.6.0 in the deploy-tests workflow for GitHub installs. This ensures tests run against the latest versions from the respective repositories. --- .github/workflows/deploy-tests.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/deploy-tests.yaml b/.github/workflows/deploy-tests.yaml index 66b41e515..b5d1b6cc7 100644 --- a/.github/workflows/deploy-tests.yaml +++ b/.github/workflows/deploy-tests.yaml @@ -84,11 +84,11 @@ jobs: uv pip uninstall shiny htmltools uv pip install shiny htmltools - - name: Install GitHub shiny@v1.0.0 and htmltools@v0.5.3 (uninstall PyPI versions) + - name: Install GitHub shiny@v1.4.0 and htmltools@v0.6.0 (uninstall PyPI versions) if: ${{ matrix.config.github_shiny }} run: | uv pip uninstall shiny htmltools - uv pip install "htmltools @ git+https://github.com/posit-dev/py-htmltools.git@v0.5.3" "shiny @ git+https://github.com/posit-dev/py-shiny.git@v1.0.0" + uv pip install "htmltools @ git+https://github.com/posit-dev/py-htmltools.git@v0.6.0" "shiny @ git+https://github.com/posit-dev/py-shiny.git@v1.4.0" - name: Install rsconnect (PyPI) if: ${{ matrix.config.pypi_rsconnect }} From a3b95766cdf72a16fffd7bf28dd5d33590e026c0 Mon Sep 17 00:00:00 2001 From: Karan Gathani Date: Thu, 11 Sep 2025 08:51:26 -0700 Subject: [PATCH 2/4] test deploys --- .github/workflows/deploy-tests.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/deploy-tests.yaml b/.github/workflows/deploy-tests.yaml index b5d1b6cc7..8b63462f0 100644 --- a/.github/workflows/deploy-tests.yaml +++ b/.github/workflows/deploy-tests.yaml @@ -3,7 +3,7 @@ name: Run deploy tests on: workflow_dispatch: push: - branches: ["main", "rc-*", "deploy-**"] + branches: ["main", "rc-*", "deploy-**", "use-latest-version"] jobs: playwright-deploys: From 5dcf3e93dcf3f2ce78db32a95ff2635a24fa0373 Mon Sep 17 00:00:00 2001 From: Karan Gathani Date: Thu, 11 Sep 2025 09:17:06 -0700 Subject: [PATCH 3/4] Add pydantic to app requirements for test deployments Added 'pydantic' to the app_requirements.txt files for several Playwright deployment test apps to ensure consistent dependency management and support for features requiring pydantic. --- tests/playwright/deploys/express-accordion/app_requirements.txt | 1 + tests/playwright/deploys/express-dataframe/app_requirements.txt | 2 +- tests/playwright/deploys/express-folium/app_requirements.txt | 2 +- .../deploys/express-page_default/app_requirements.txt | 2 +- .../deploys/express-page_fillable/app_requirements.txt | 1 + .../playwright/deploys/express-page_fluid/app_requirements.txt | 2 +- .../deploys/express-page_sidebar/app_requirements.txt | 2 +- tests/playwright/deploys/plotly/app_requirements.txt | 2 +- .../deploys/shiny-client-console-error/app_requirements.txt | 2 +- 9 files changed, 9 insertions(+), 7 deletions(-) diff --git a/tests/playwright/deploys/express-accordion/app_requirements.txt b/tests/playwright/deploys/express-accordion/app_requirements.txt index e09d417b0..87dfecf41 100644 --- a/tests/playwright/deploys/express-accordion/app_requirements.txt +++ b/tests/playwright/deploys/express-accordion/app_requirements.txt @@ -1 +1,2 @@ htmltools +pydantic diff --git a/tests/playwright/deploys/express-dataframe/app_requirements.txt b/tests/playwright/deploys/express-dataframe/app_requirements.txt index fe0e96905..0b6e152d4 100644 --- a/tests/playwright/deploys/express-dataframe/app_requirements.txt +++ b/tests/playwright/deploys/express-dataframe/app_requirements.txt @@ -1,3 +1,3 @@ htmltools pandas - +pydantic diff --git a/tests/playwright/deploys/express-folium/app_requirements.txt b/tests/playwright/deploys/express-folium/app_requirements.txt index 0342f05fd..a06df4a41 100644 --- a/tests/playwright/deploys/express-folium/app_requirements.txt +++ b/tests/playwright/deploys/express-folium/app_requirements.txt @@ -1,3 +1,3 @@ htmltools folium - +pydantic diff --git a/tests/playwright/deploys/express-page_default/app_requirements.txt b/tests/playwright/deploys/express-page_default/app_requirements.txt index ff9c64288..87dfecf41 100644 --- a/tests/playwright/deploys/express-page_default/app_requirements.txt +++ b/tests/playwright/deploys/express-page_default/app_requirements.txt @@ -1,2 +1,2 @@ htmltools - +pydantic diff --git a/tests/playwright/deploys/express-page_fillable/app_requirements.txt b/tests/playwright/deploys/express-page_fillable/app_requirements.txt index e09d417b0..87dfecf41 100644 --- a/tests/playwright/deploys/express-page_fillable/app_requirements.txt +++ b/tests/playwright/deploys/express-page_fillable/app_requirements.txt @@ -1 +1,2 @@ htmltools +pydantic diff --git a/tests/playwright/deploys/express-page_fluid/app_requirements.txt b/tests/playwright/deploys/express-page_fluid/app_requirements.txt index ff9c64288..87dfecf41 100644 --- a/tests/playwright/deploys/express-page_fluid/app_requirements.txt +++ b/tests/playwright/deploys/express-page_fluid/app_requirements.txt @@ -1,2 +1,2 @@ htmltools - +pydantic diff --git a/tests/playwright/deploys/express-page_sidebar/app_requirements.txt b/tests/playwright/deploys/express-page_sidebar/app_requirements.txt index ff9c64288..87dfecf41 100644 --- a/tests/playwright/deploys/express-page_sidebar/app_requirements.txt +++ b/tests/playwright/deploys/express-page_sidebar/app_requirements.txt @@ -1,2 +1,2 @@ htmltools - +pydantic diff --git a/tests/playwright/deploys/plotly/app_requirements.txt b/tests/playwright/deploys/plotly/app_requirements.txt index 7df8afb67..e948d0a61 100644 --- a/tests/playwright/deploys/plotly/app_requirements.txt +++ b/tests/playwright/deploys/plotly/app_requirements.txt @@ -3,4 +3,4 @@ plotly anywidget htmltools git+https://github.com/posit-dev/py-shinywidgets.git#egg=shinywidgets - +pydantic diff --git a/tests/playwright/deploys/shiny-client-console-error/app_requirements.txt b/tests/playwright/deploys/shiny-client-console-error/app_requirements.txt index ff9c64288..87dfecf41 100644 --- a/tests/playwright/deploys/shiny-client-console-error/app_requirements.txt +++ b/tests/playwright/deploys/shiny-client-console-error/app_requirements.txt @@ -1,2 +1,2 @@ htmltools - +pydantic From 214f2ee2cc851a7d5d89cd489914b22067ae9ea0 Mon Sep 17 00:00:00 2001 From: Karan Gathani Date: Thu, 11 Sep 2025 09:28:40 -0700 Subject: [PATCH 4/4] Remove 'use-latest-version' branch from deploy tests The deploy tests workflow will no longer run on pushes to the 'use-latest-version' branch. This streamlines workflow triggers to only relevant branches. --- .github/workflows/deploy-tests.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/deploy-tests.yaml b/.github/workflows/deploy-tests.yaml index 8b63462f0..b5d1b6cc7 100644 --- a/.github/workflows/deploy-tests.yaml +++ b/.github/workflows/deploy-tests.yaml @@ -3,7 +3,7 @@ name: Run deploy tests on: workflow_dispatch: push: - branches: ["main", "rc-*", "deploy-**", "use-latest-version"] + branches: ["main", "rc-*", "deploy-**"] jobs: playwright-deploys: