testing new approach

Author: joshyam-k

pyproject.toml

@@ -14,8 +14,7 @@ dependencies = [
     "pyjwt>=2.4.0",
     "click>=8.0.0",
     "toml>=0.10; python_version < '3.11'",
-    "fastmcp",
-    "posit-sdk"
+    "fastmcp"
 ]
 
 dynamic = ["version"]

rsconnect/main.py

@@ -3,7 +3,6 @@
 import functools
 import json
 import os
-import subprocess
 import sys
 import textwrap
 import traceback
@@ -14,7 +13,6 @@
     Callable,
     Dict,
     ItemsView,
-    List,
     Literal,
     Optional,
     Sequence,
@@ -420,80 +418,119 @@ def version():
 def mcp_server(server: str, api_key: str):
     from fastmcp import FastMCP
     from fastmcp.exceptions import ToolError
-    from posit.connect import Client
 
     mcp = FastMCP("Connect MCP")
 
-    def get_content_logs(app_guid: str):
-        try:
-            client = Client(server, api_key)
-            response = client.get(f"v1/content/{app_guid}/jobs")
-            jobs = response.json()
-            # first job key is the most recent one
-            key = jobs[0]["key"]
-            logs = client.get(f"v1/content/{app_guid}/jobs/{key}/log")
-            return logs.json()
-        except Exception as e:
-            raise ToolError(f"Failed to get logs: {e}")
-
-    def list_content():
-        try:
-            client = Client(server, api_key)
-            response = client.get("v1/content")
-            return response.json()
-        except Exception as e:
-            raise ToolError(f"Failed to list content: {e}")
+    # Discover all deploy commands at startup
+    from .mcp_deploy_discovery import discover_deploy_commands
+    deploy_commands_info = discover_deploy_commands(cli)
 
-    def get_content_item(app_guid: str):
-        try:
-            client = Client(server, api_key)
-            response = client.content.get(app_guid)
-            return response
-        except Exception as e:
-            raise ToolError(f"Failed to get content: {e}")
+    @mcp.tool()
+    async def add_server(
+        server_url: str,
+        nickname: str,
+        api_key: str,
+    ) -> Dict[str, Any]:
+        """Prompt user to add a Posit Connect server using rsconnect add.
+
+        This tool guides users through registering a Connect server so they can use
+        rsconnect deployment commands. The server nickname allows you to reference
+        the server in future deployment commands.
+
+        Args:
+            server_url: The URL of your Posit Connect server (e.g., https://my.connect.server/)
+            nickname: A nickname you choose for the server (e.g., myServer)
+            api_key: Your personal API key for authentication
+
+        Returns:
+            A dictionary containing the command to run and instructions
+        """
+        command = f"rsconnect add --server {server_url} --name {nickname} --api-key {api_key}"
+
+        return {
+            "command": command,
+            "message": f"Run the following command to add your Posit Connect server:\n\n{command}\n\n"
+                      f"This will:\n"
+                      f"1. Register '{server_url}' with the nickname '{nickname}'\n"
+                      f"2. Validate the server connection and API key\n"
+                      f"3. Store the credentials securely for future deployments\n\n"
+                      f"After adding the server, you can deploy content using commands like:\n"
+                      f"  rsconnect deploy shiny <directory> --name {nickname}",
+            "next_steps": [
+                "Run the add command shown above",
+                "Verify the server was added with: rsconnect list",
+                "Deploy content using the nickname: rsconnect deploy <type> <path> --name " + nickname
+            ]
+        }
 
     @mcp.tool()
-    async def deploy_shiny(
-        directory: str,
-        name: Optional[str] = None,
-        title: Optional[str] = None
+    async def build_deploy_command(
+        application_type: str,
+        parameters: Dict[str, Any]
     ) -> Dict[str, Any]:
-        """Deploy a Shiny application to Posit Connect"""
+        """Build a deploy command for any content type using discovered parameters.
+
+        This tool automatically builds the correct rsconnect deploy command
+        with proper parameter names and types based on the command type.
+
+        Args:
+            command_type: The type of content to deploy (e.g., 'shiny', 'notebook', 'quarto', etc.)
+            parameters: Dictionary of parameter names and their values
+
+        Returns:
+            Dictionary with the generated command and explanation
+        """
+        # Use the deploy commands info discovered at startup
+        deploy_info = deploy_commands_info
+
+        if application_type not in deploy_info["commands"]:
+            available = ", ".join(deploy_info["commands"].keys())
+            raise ToolError(
+                f"Unknown application type '{application_type}'. "
+                f"Available types: {available}"
+            )
 
-        # Build the CLI command
-        args = ["deploy", "shiny", directory]
+        cmd_parts = ["rsconnect", "deploy", application_type]
+        cmd_info = deploy_info["commands"][application_type]
 
-        if name:
-            args.extend(["--name", name])
+        arguments = [p for p in cmd_info["parameters"] if p.get("param_type") == "argument"]
+        options = [p for p in cmd_info["parameters"] if p.get("param_type") == "option"]
 
-        if title:
-            args.extend(["--title", title])
+        # add arguments
+        for arg in arguments:
+            if arg["name"] in parameters:
+                value = parameters[arg["name"]]
+                if value:
+                    cmd_parts.append(str(value))
 
-        args.extend(["--server", server])
-        args.extend(["--api-key", api_key])
+        # add options
+        for opt in options:
+            param_name = opt["name"]
+            if param_name not in parameters:
+                continue
 
-        try:
-            result = subprocess.run(
-                args,
-                check=True,
-                capture_output=True,
-                text=True
-            )
-            return {
-                "success": True,
-                "message": "Deployment completed successfully",
-                "stdout": result.stdout,
-                "stderr": result.stderr
-            }
-        except subprocess.CalledProcessError as e:
-            raise ToolError(f"Deployment failed with exit code {e.returncode}: {e.stderr}")
-        except Exception as e:
-            raise ToolError(f"Command failed with error: {e}")
-
-
-    mcp.tool(description="Get content logs from Posit Connect")(get_content_logs)
-    mcp.tool(description="List content from Posit Connect")(list_content)
-    mcp.tool(description="Get content item from Posit Connect")(get_content_item)
+            value = parameters[param_name]
+            if value is None or value is False or value == "":
+                continue
+
+            cli_flag = max(opt.get("cli_flags", []), key=len) if opt.get("cli_flags") else f"--{param_name.replace('_', '-')}"
+
+            if opt["type"] == "boolean" and value:
+                cmd_parts.append(cli_flag)
+            elif opt["type"] == "array" and isinstance(value, list):
+                for item in value:
+                    cmd_parts.extend([cli_flag, str(item)])
+            else:
+                cmd_parts.extend([cli_flag, str(value)])
+
+        command = " ".join(cmd_parts)
+
+        return {
+            "command": command,
+            "application_type": application_type,
+            "description": cmd_info["description"],
+            "message": f"Run the following command to deploy your {application_type} content:\n\n{command}",
+        }
 
     mcp.run()
 

rsconnect/mcp_deploy_discovery.py

@@ -0,0 +1,107 @@
+"""
+Programmatically discover all parameters for rsconnect deploy commands.
+This helps MCP tools understand exactly how to use `rsconnect deploy ...`
+"""
+
+from typing import Any, Dict
+
+import click
+
+
+def extract_parameter_info(param: click.Parameter) -> Dict[str, Any]:
+    """Extract detailed information from a Click parameter."""
+    info: Dict[str, Any] = {
+        "type": "string",  # default
+    }
+
+    if isinstance(param, click.Option) and param.opts:
+        # Use the longest option name (usually the full form without dashes)
+        mcp_arg_name = max(param.opts, key=len).lstrip('-').replace('-', '_')
+        info["name"] = mcp_arg_name
+        info["cli_flags"] = param.opts
+        info["param_type"] = "option"
+    else:
+        info["name"] = param.name
+        if isinstance(param, click.Argument):
+            info["param_type"] = "argument"
+
+    # extract help text for added context
+    help_text = getattr(param, 'help', None)
+    if help_text:
+        info["description"] = help_text
+
+    if isinstance(param, click.Option):
+        # Boolean flags
+        if param.is_flag:
+            info["type"] = "boolean"
+            info["default"] = param.default or False
+
+        # choices
+        elif param.type and hasattr(param.type, 'choices'):
+            info["type"] = "string"
+            info["choices"] = list(param.type.choices)
+
+        # multiple
+        elif param.multiple:
+            info["type"] = "array"
+            info["items"] = {"type": "string"}
+
+        # files
+        elif isinstance(param.type, click.Path):
+            info["type"] = "string"
+            info["format"] = "path"
+            if param.type.exists:
+                info["path_must_exist"] = True
+            if param.type.file_okay and not param.type.dir_okay:
+                info["path_type"] = "file"
+            elif param.type.dir_okay and not param.type.file_okay:
+                info["path_type"] = "directory"
+
+        # defaults (important to avoid noise in returned command)
+        if param.default is not None and not param.is_flag:
+            info["default"] = param.default
+
+    # required params
+    info["required"] = param.required
+
+    return info
+
+
+def discover_deploy_commands(cli_group: click.Group) -> Dict[str, Any]:
+    """Discover all deploy commands and their parameters."""
+
+    if "deploy" not in cli_group.commands:
+        return {"error": "deploy command group not found"}
+
+    deploy_group = cli_group.commands["deploy"]
+
+    if not isinstance(deploy_group, click.Group):
+        return {"error": "deploy is not a command group"}
+
+    result = {
+        "group_name": "deploy",
+        "description": deploy_group.help or "Deploy content to Posit Connect, Posit Cloud, or shinyapps.io.",
+        "commands": {}
+    }
+
+    for cmd_name, command in deploy_group.commands.items():
+        cmd_info = {
+            "name": cmd_name,
+            "description": command.help or command.short_help or f"Deploy {cmd_name}",
+            "short_help": command.short_help,
+            "parameters": []
+        }
+        for param in command.params:
+            # Skip context parameters
+            if isinstance(param, click.Context):
+                continue
+
+            if param.name in ["verbose", "v"]:
+                continue
+
+            param_info = extract_parameter_info(param)
+            cmd_info["parameters"].append(param_info)
+
+        result["commands"][cmd_name] = cmd_info
+
+    return result