Skip to content

Commit 8533b4f

Browse files
authored
fix(helm): remove duplicate metrics service causing install failures (#83)
1 parent b642da5 commit 8533b4f

File tree

2 files changed

+4
-17
lines changed

2 files changed

+4
-17
lines changed

Makefile

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -181,6 +181,10 @@ helm-generate: manifests kubebuilder ## Regenerate Helm chart from kustomize
181181
$(SED) -i 's/team-operator-controller-manager-metrics-service/{{ .Values.controllerManager.serviceAccountName }}-metrics-service/g' dist/chart/templates/metrics/metrics-service.yaml
182182
# Fix RoleBinding namespace to use watchNamespace value
183183
$(SED) -i '/kind: RoleBinding/,/roleRef:/{s/namespace: posit-team/namespace: {{ .Values.watchNamespace }}/}' dist/chart/templates/rbac/role_binding.yaml
184+
# Remove duplicate metrics service that kubebuilder generates - we already have one in dist/chart/templates/metrics/
185+
# This was causing "services 'team-operator-controller-manager-metrics-service' already exists" errors
186+
# The correct metrics service is gated on .Values.metrics.enable, not .Values.rbac.enable
187+
rm -f dist/chart/templates/rbac/auth_proxy_service.yaml
184188
# Remove kubebuilder-generated test workflow - we use our own CI workflows
185189
rm -f .github/workflows/test-chart.yml
186190

dist/chart/templates/rbac/auth_proxy_service.yaml

Lines changed: 0 additions & 17 deletions
This file was deleted.

0 commit comments

Comments
 (0)