Bug #50889: Remove Postcode.nl Api used message from mails to customers

BastiaanGrutters · BastiaanGrutters · commit 16b54e8e7332 · 2020-02-26T15:59:09.000+01:00
- Fixed unused installer/upgrader scripts
diff --git a/app/code/community/Mage42/PostcodeNL/Model/Observer.php b/app/code/community/Mage42/PostcodeNL/Model/Observer.php
@@ -3,9 +3,6 @@ class Mage42_PostcodeNL_Model_Observer
 {
    public function saveUsedPostcodenlApi($observer)
    {
-       $event = $observer->getEvent();
-       /** @var Mage_Sales_Model_Order $order */
-       $order = $event->getOrder();
-       $order->setCustomerNote("Used postcodenl API");
+		// Do not overwrite customer_note
    }
 }
diff --git a/app/code/community/Mage42/PostcodeNL/etc/config.xml b/app/code/community/Mage42/PostcodeNL/etc/config.xml
@@ -22,7 +22,6 @@
                 </mage42_postcodenl>
             </updates>
         </layout>
-
     </frontend>
     <admin>
         <routers>
diff --git a/app/code/community/Mage42/PostcodeNL/sql/postcodenl_setup/mysql4-install-0.1.2.php b/app/code/community/Mage42/PostcodeNL/sql/postcodenl_setup/mysql4-install-0.1.2.php
@@ -1,5 +1,6 @@
 <?php
 
+$installer = $this;
 $installer->startSetup();
 $connection = $installer->getConnection();
 
diff --git a/app/code/community/Mage42/PostcodeNL/sql/postcodenl_setup/mysql4-upgrade-0.1.1-0.1.2.php b/app/code/community/Mage42/PostcodeNL/sql/postcodenl_setup/mysql4-upgrade-0.1.1-0.1.2.php
@@ -1,6 +1,6 @@
 <?php
 
-$install = $this;
+$installer = $this;
 $installer->startSetup();
 $connection = $installer->getConnection();
 

Original file line number	Diff line number	Diff line change
`@@ -3,9 +3,6 @@ class Mage42_PostcodeNL_Model_Observer`
`3`	`3`	`{`
`4`	`4`	`public function saveUsedPostcodenlApi($observer)`
`5`	`5`	`{`
`6`		`- $event = $observer->getEvent();`
`7`		`- /** @var Mage_Sales_Model_Order $order */`
`8`		`- $order = $event->getOrder();`
`9`		`- $order->setCustomerNote("Used postcodenl API");`
	`6`	`+ // Do not overwrite customer_note`
`10`	`7`	`}`
`11`	`8`	`}`