Merge pull request #110 from aadmathijssen/fix/fix-type-error-when-obtaining-module-version

JerrySmidt · web-flow · commit 3331b8922d35 · 2025-06-30T11:21:48.000+02:00
Fix type error in \Flekto\Postcode\Helper\StoreConfigHelper::getModuleVersion method
diff --git a/Helper/ApiClientHelper.php b/Helper/ApiClientHelper.php
@@ -505,7 +505,7 @@ private function _getDebugInfo(): array
         ];
 
         // Module version
-        $debug['moduleVersion'] = $this->_storeConfigHelper->getValue('module_version');
+        $debug['moduleVersion'] = $this->_storeConfigHelper->getModuleVersion();
 
         // Magento version
         $version = $this->_productMetadata->getVersion();
diff --git a/Helper/StoreConfigHelper.php b/Helper/StoreConfigHelper.php
@@ -164,7 +164,7 @@ public function getCredentials(): array
      */
     public function getModuleVersion(): string
     {
-        return $this->getValue('module_version');
+        return $this->getValue('module_version') ?? 'UNKNOWN';
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -164,7 +164,7 @@ public function getCredentials(): array`
`164`	`164`	`*/`
`165`	`165`	`public function getModuleVersion(): string`
`166`	`166`	`{`
`167`		`- return $this->getValue('module_version');`
	`167`	`+ return $this->getValue('module_version') ?? 'UNKNOWN';`
`168`	`168`	`}`
`169`	`169`
`170`	`170`	`/**`