Checkout fields not showing with minified/bundled version

[Paulsky]

When I enable minify and bundling (with magepack), Javascript errors are thrown and the checkout fields fail to load:

Cannot read properties of undefined (reading 'show_hide_address_fields') house-number-select.js line 18

Cannot read properties of undefined (reading 'setOptions') address-autofill-nl.js line 171

I suspect (not sure!) this is related to: #59

[marceldekoning]

@Paulsky,

Is there any news on this issue? With Magepack enabled and the patch from #77 installed, the address fields are still showed while this should be hidden.

Somehow, the data-bind="visible: visible,..." is gone on the street fieldset.

I hope someone has an anwer to this.

[Paulsky]

@marceldekoning I'm afraid I don't have any news on this issue. Did you try my changes in my pull request?

Do you have Javascript errors in the console?

[marceldekoning]

Hi @Paulsky,

After regenerating the magepack.config.js and bundles again, it worked after patching the module with your PR. For anyone who needs this too, I created a patch file for version 3.1.9:

https://pastebin.com/L6rKvcDt

All credits to @Paulsky off course! Thanks.

[Paulsky]

Great to hear that @marceldekoning and really nice of you for creating a patch! 🙏 Good to know my PR is also fixing your issue.

@JerrySmidt what do you think?

[JerrySmidt]

Magento 2.4.6 with minified and Magepack-bundled files seems to work without any errors on release 3.1.9.

Is there anything else needed to reproduce this issue? Could you provide more info on how exactly to reproduce this issue (e.g. any other settings, modules etc that affect this)?

Otherwise we can't test for this issue and a future module version could have the same issue again.

Thanks for your efforts.

[Paulsky]

Thank you for your reply @JerrySmidt . Did you test it with the onestep checkout module from onestepcheckout-dot-com?

[JerrySmidt]

@Paulsky, no I don't have that module,

But assuming you have it, could you check with onestepcheckout-dot-com disabled to see if you still get the error?

[Paulsky]

@JerrySmidt I will check it. But could you have a look at my PR. It's mostly only checking if some variables are set or not.

@marceldekoning are you also using OneStepCheckout from onestepcheckout-dot-com?

[marceldekoning]

@Paulsky,

No, I'm not using OSC, but just the native checkout with Magento 2.4.5-p1. I did not test this on 2.4.6 tho.

[Paulsky]

Thanks @marceldekoning. @JerrySmidt FYI: the screenshots in #72 (comment) seems to show the same problem (this.settings is undefined).

[hd-jeroen]

This issue still persists using version 3.1.11 on Magento 2.4.6-p2 without minified/bundled JS, but only the first time after the cache has been cleared.