Skip to content

Suggestion: use :not(.is-dark) as lightSelector by default #35

@aletorrado

Description

@aletorrado

Hi,

This is a very subjective matter, but I wanted to suggest you for the sake of simplicity, to just use a negated :not(.is-dark) selector as the default lightSelector. Even, the plugin may compute something like :not(<darkSelector>), so that the user can safely override darkSelector preserving the same behavior.

Using a single class or attribute seems like a good idea to simplify JS manipulation and avoid invalid states if by any means both is-light and is-dark are triggered.

If you agree with this, I would be glad to submit a PR.

Thanks!

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions