Skip to content

Commit e20cfbc

Browse files
committed
don't run these tests that fail on node v6.
1 parent a38fe31 commit e20cfbc

File tree

4 files changed

+26
-13
lines changed

4 files changed

+26
-13
lines changed

package-lock.json

Lines changed: 7 additions & 7 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,8 @@
2020
"glob": "^7.0.3",
2121
"minimist": "^1.2.0",
2222
"nyc": "^11.4.1",
23-
"postcss": "^6.0.6"
23+
"postcss": "^6.0.6",
24+
"semver": "^5.5.0"
2425
},
2526
"main": "dist/index.js",
2627
"types": "postcss-selector-parser.d.ts",

src/__tests__/attributes.js

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import process from "process";
22
import Attribute from '../selectors/attribute';
3-
import {test} from './util/helpers';
3+
import {test, nodeVersionAtLeast, nodeVersionBefore} from './util/helpers';
44

55
process.throwDeprecation = true;
66

@@ -397,7 +397,9 @@ test('non standard modifiers', '[href="foo" y]', (t, tree) => {
397397
t.deepEqual(tree.toString(), '[href="foo" y]');
398398
});
399399

400-
test('deprecated constructor', '', (t) => {
400+
const testDeprecation = nodeVersionAtLeast('7.0.0') || nodeVersionBefore('6.0.0') ? test : test.skip;
401+
402+
testDeprecation('deprecated constructor', '', (t) => {
401403
t.throws(
402404
() => {
403405
return new Attribute({value: '"foo"', attribute: "data-bar"});
@@ -406,7 +408,7 @@ test('deprecated constructor', '', (t) => {
406408
);
407409
});
408410

409-
test('deprecated get of raws.unquoted ', '', (t) => {
411+
testDeprecation('deprecated get of raws.unquoted ', '', (t) => {
410412
t.throws(
411413
() => {
412414
let attr = new Attribute({value: 'foo', quoteMark: '"', attribute: "data-bar"});
@@ -416,7 +418,7 @@ test('deprecated get of raws.unquoted ', '', (t) => {
416418
);
417419
});
418420

419-
test('deprecated set of raws.unquoted ', '', (t) => {
421+
testDeprecation('deprecated set of raws.unquoted ', '', (t) => {
420422
t.throws(
421423
() => {
422424
let attr = new Attribute({value: 'foo', quoteMark: '"', attribute: "data-bar"});
@@ -426,7 +428,7 @@ test('deprecated set of raws.unquoted ', '', (t) => {
426428
);
427429
});
428430

429-
test('smart quotes', '[data-foo=bar]', (t, tree) => {
431+
testDeprecation('smart quotes', '[data-foo=bar]', (t, tree) => {
430432
let attr = tree.nodes[0].nodes[0];
431433
attr.setValue('changed', {quoteMark: '"'});
432434
t.deepEqual(attr.toString(), '[data-foo="changed"]');

src/__tests__/util/helpers.js

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
1+
import process from 'process';
12
import util from 'util';
23
import ava from 'ava';
4+
import semver from 'semver';
35
import parser from '../../index';
46

57
export const parse = (input, transform) => {
@@ -34,3 +36,11 @@ export const throws = (spec, input, validator) => {
3436
t.throws(() => parser().processSync(input), validator);
3537
});
3638
};
39+
40+
export function nodeVersionAtLeast (version) {
41+
return semver.gte(process.versions.node, version);
42+
}
43+
44+
export function nodeVersionBefore (version) {
45+
return semver.lt(process.versions.node, version);
46+
}

0 commit comments

Comments
 (0)