feat: allow ipv6 services (#218)

* feat: allow ipv6 services

* test(servicecheck): add ipv6.google.com check

---------

Co-authored-by: Clément Nussbaumer <clement@n8r.ch>

Author: borislitv

internal/servicecheck/servicecheck.go

@@ -143,7 +143,7 @@ func (c *Checker) APIServerDirect(ctx context.Context) string {
 		return skippedStr
 	}
 
-	apiurl := fmt.Sprintf("https://%s:%s/version", c.KubernetesServiceHost, c.KubernetesServicePort)
+	apiurl := fmt.Sprintf("https://%s/version", net.JoinHostPort(c.KubernetesServiceHost, c.KubernetesServicePort))
 
 	return c.doRequest(ctx, apiurl, false)
 }
@@ -154,7 +154,7 @@ func (c *Checker) APIServerDNS(ctx context.Context) string {
 		return skippedStr
 	}
 
-	apiurl := fmt.Sprintf("https://%s:%s/version", c.KubernetesServiceDNS, c.KubernetesServicePort)
+	apiurl := fmt.Sprintf("https://%s/version", net.JoinHostPort(c.KubernetesServiceDNS, c.KubernetesServicePort))
 
 	return c.doRequest(ctx, apiurl, false)
 }
@@ -190,8 +190,8 @@ func (c *Checker) measure(ctx context.Context, wg *sync.WaitGroup, res *sync.Map
 
 func podIPtoURL(podIP string, useTLS bool) string {
 	if useTLS {
-		return "https://" + podIP + ":8443/alwayshappy"
+		return "https://" + net.JoinHostPort(podIP, "8443") + "/alwayshappy"
 	}
 
-	return "http://" + podIP + ":8080/alwayshappy"
+	return "http://" + net.JoinHostPort(podIP, "8080") + "/alwayshappy"
 }

internal/servicecheck/servicecheck_test.go

@@ -57,6 +57,7 @@ func TestCombined(t *testing.T) {
 	checker.ExtraChecks = map[string]string{
 		"check_not_found": server.URL + "/not-found",
 		"check_ok":        server.URL + "/ok",
+		"check_ipv6":      "https://ipv6.google.com/",
 	}
 	r.NoError(err)
 	r.NotNil(checker)
@@ -67,6 +68,7 @@ func TestCombined(t *testing.T) {
 
 		r.Equal(okStr, checker.LastCheckResult[NeighbourhoodState])
 		r.Equal(okStr, checker.LastCheckResult["check_ok"])
+		// r.Equal(okStr, checker.LastCheckResult["check_ipv6"]) // gh-action doesn't support IPv6 yet
 		r.Equal("404 Not Found", checker.LastCheckResult["check_not_found"])
 	})
 }