Problem: building unreleased extensions

Sometimes this is necessary for testing. But we depend on published
versions.

Solution: allow specify a path to the source code

`#with_path` in code and `--path` using command line

Author: yrashk

exe/pgpm

@@ -37,10 +37,11 @@ module Pgpm
         option :arch, type: :string, default: Pgpm::Arch.host.name, desc: "Target architecture"
         option :pgdist, type: :string, default: "pgdg", desc: "Target Postgres distribution"
         option :pgver, type: :string, default: Pgpm::Postgres::Distribution.versions.last.to_s, desc: "Target Postgres version"
+        option :path, type: :path, desc: "Override path to the source"
         argument :packages, type: :array, required: true, desc: "Package names"
 
         # rubocop:disable Metrics/ParameterLists:
-        def call(packages:, args: nil, os: nil, arch: nil, pgdist: nil, pgver: nil, pkgdir: nil)
+        def call(packages:, args: nil, os: nil, arch: nil, pgdist: nil, pgver: nil, pkgdir: nil, path: nil)
           _ = args
           _ = os
           _ = pgdist
@@ -61,7 +62,7 @@ module Pgpm
               puts "Can't build a contrib package"
               exit(1)
             end
-            pkg = p[version]
+            pkg = path.nil? ? p[version] : p.new(version).with_path(path)
             if pkg.nil?
               puts "Package #{name} with version #{version} not found"
               exit(1)

lib/pgpm/package.rb

@@ -6,7 +6,7 @@ module Pgpm
   class Package
     include Pgpm::Aspects::InheritanceTracker
     include AbstractPackage
-    include Sources
+    include Source
     include Naming
     include Metadata
     include Dependencies
@@ -23,6 +23,7 @@ class Package
     include Initialization
     include Packaging
     include Contrib
+    include WithPath
 
     def inspect
       "#<#{self.class}:#{self.class.package_name} #{version}>"

lib/pgpm/package/sources.rb renamed to lib/pgpm/package/source.rb

@@ -2,7 +2,11 @@
 
 module Pgpm
   class Package
-    module Sources
+    module Source
+      def source
+        raise StandardError, "no source specified"
+      end
+
       def sources
         []
       end

lib/pgpm/package/with_path.rb

@@ -0,0 +1,64 @@
+# frozen_string_literal: true
+
+require "minitar"
+require "find"
+require "zlib"
+
+module Pgpm
+  class Package
+    module WithPath
+      def with_path(path)
+        @with_path = File.absolute_path(path)
+        self
+      end
+
+      def source_url_directory_name
+        if @with_path
+          File.basename(@with_path)
+        else
+          super
+        end
+      end
+
+      def source
+        if @with_path
+          Pathname(@with_path)
+        else
+          super
+        end
+      end
+
+      def sources
+        if @with_path
+          [source_tar_gz]
+        else
+          super
+        end
+      end
+
+      private
+
+      def source_tar_gz
+        Pgpm::OnDemandFile.new("sources.tar.gz", lambda {
+          s = String.new
+          begin
+            dir = source
+            sgz = Zlib::GzipWriter.new(StringIO.new(s))
+            tar = Minitar::Output.open(sgz)
+            Find.find(dir) do |entry|
+              stat = File.stat(entry)
+              data = File.directory?(entry) ? nil : File.binread(entry)
+              info = { name: Pathname(entry).relative_path_from(File.dirname(source)).to_s,
+                       mode: stat.mode, uid: stat.uid, gid: stat.gid, mtime: stat.mtime }
+              Minitar.pack_as_file(info, data, tar)
+            end
+          ensure
+            # Closes both tar and sgz.
+            tar.close
+          end
+          StringIO.open(s)
+        })
+      end
+    end
+  end
+end

packages/omnigres/package.rb

@@ -182,7 +182,7 @@ def artifacts(src = nil)
         rescue Git::GitExecuteError
           share_fix = "-e PGSHAREDIR=#{pgpath}/build/share"
         end
-        unless Pgpm::Podman.run "run -ti #{share_fix} -v #{Pgpm::Cache.directory}:#{Pgpm::Cache.directory} #{PGPM_BUILD_CONTAINER_IMAGE}  cmake -S #{src} -B #{src}/build -DOPENSSL_CONFIGURED=1 -DPGVER=#{Pgpm::Postgres::Distribution.in_scope.version} -DPGDIR=#{pgpath}"
+        unless Pgpm::Podman.run "run -ti #{share_fix} -v #{source}:#{source} -v #{Pgpm::Cache.directory}:#{Pgpm::Cache.directory} #{PGPM_BUILD_CONTAINER_IMAGE}  cmake -S #{src} -B #{src}/build -DOPENSSL_CONFIGURED=1 -DPGVER=#{Pgpm::Postgres::Distribution.in_scope.version} -DPGDIR=#{pgpath}"
           raise "Can't configure the project"
         end
 
@@ -258,6 +258,7 @@ def previous_version
 
       sorted_versions = self.class.package_versions.sort
       index = sorted_versions.index(version)
+      return nil if index.nil?
       return unless index.positive?
 
       @previous_version = self.class[sorted_versions[index - 1]]