Fix tags dropdown on the homepage and abstract away logic

Author: JelteF

pgcommitfest/commitfest/views.py

@@ -49,6 +49,21 @@
 )
 
 
+def get_tags_data():
+    """Generate JSON data for enhanced selectize dropdown with tag colors and descriptions."""
+    return json.dumps(
+        [
+            {
+                "id": tag.id,
+                "name": tag.name,
+                "color": tag.color,
+                "description": tag.description,
+            }
+            for tag in Tag.objects.all().order_by("name")
+        ]
+    )
+
+
 @transaction.atomic
 def home(request):
     curs = connection.cursor()
@@ -117,6 +132,7 @@ def home(request):
                 "form": form,
                 "patches": patch_list.patches,
                 "statussummary": statussummary,
+                "tags_data": get_tags_data(),
                 "all_tags": {t.id: t for t in Tag.objects.all()},
                 "has_filter": patch_list.has_filter,
                 "grouping": patch_list.sortkey == 0,
@@ -605,21 +621,6 @@ def commitfest(request, cfid):
     # the user is logged in. XXX: Figure out how to avoid doing that..
     form = CommitFestFilterForm(request.GET)
 
-    # Prepare tag data for enhanced selectize dropdown
-    import json
-
-    tags_data = json.dumps(
-        [
-            {
-                "id": tag.id,
-                "name": tag.name,
-                "color": tag.color,
-                "description": tag.description,
-            }
-            for tag in Tag.objects.all().order_by("name")
-        ]
-    )
-
     return render(
         request,
         "commitfest.html",
@@ -628,7 +629,7 @@ def commitfest(request, cfid):
             "form": form,
             "patches": patch_list.patches,
             "statussummary": statussummary,
-            "tags_data": tags_data,
+            "tags_data": get_tags_data(),
             "all_tags": {t.id: t for t in Tag.objects.all()},
             "has_filter": patch_list.has_filter,
             "title": f"{cf.title} ({cf.periodstring})",
@@ -822,21 +823,6 @@ def patchform(request, patchid):
     else:
         form = PatchForm(instance=patch)
 
-    # Prepare tag data for enhanced selectize dropdown
-    import json
-
-    tags_data = json.dumps(
-        [
-            {
-                "id": tag.id,
-                "name": tag.name,
-                "color": tag.color,
-                "description": tag.description,
-            }
-            for tag in Tag.objects.all().order_by("name")
-        ]
-    )
-
     return render(
         request,
         "base_form.html",
@@ -845,7 +831,7 @@ def patchform(request, patchid):
             "form": form,
             "patch": patch,
             "title": "Edit patch",
-            "tags_data": tags_data,
+            "tags_data": get_tags_data(),
             "breadcrumbs": [
                 {"title": cf.title, "href": "/%s/" % cf.pk},
                 {"title": "View patch", "href": "/%s/%s/" % (cf.pk, patch.pk)},
@@ -894,28 +880,13 @@ def newpatch(request, cfid):
     else:
         form = NewPatchForm(request=request)
 
-    # Prepare tag data for enhanced selectize dropdown
-    import json
-
-    tags_data = json.dumps(
-        [
-            {
-                "id": tag.id,
-                "name": tag.name,
-                "color": tag.color,
-                "description": tag.description,
-            }
-            for tag in Tag.objects.all().order_by("name")
-        ]
-    )
-
     return render(
         request,
         "base_form.html",
         {
             "form": form,
             "title": "New patch",
-            "tags_data": tags_data,
+            "tags_data": get_tags_data(),
             "breadcrumbs": [
                 {"title": f"{cf.title} ({cf.periodstring})", "href": "/%s/" % cf.pk},
             ],