File tree Expand file tree Collapse file tree 1 file changed +7
-0
lines changed
Expand file tree Collapse file tree 1 file changed +7
-0
lines changed Original file line number Diff line number Diff line change @@ -375,7 +375,14 @@ class CfbotTask(models.Model):
375375 ('ERRORED' , 'Errored' ),
376376 ]
377377
378+ # This id is only used by Django. Using text type for primary keys, has
379+ # historically caused problems.
378380 id = models .BigAutoField (primary_key = True )
381+ # This is the id used by the external CI system. Currently with CirrusCI
382+ # this is an integer, and thus we could probably store it as such. But
383+ # given that we might need to change CI providers at some point, and that
384+ # CI provider might use e.g. UUIDs, we prefer to consider the format of the
385+ # ID opaque and store it as text.
379386 task_id = models .TextField (unique = True )
380387 task_name = models .TextField (null = False )
381388 patch = models .ForeignKey (Patch , on_delete = models .CASCADE , related_name = "cfbot_tasks" )
You can’t perform that action at this time.
0 commit comments