Skip to content

Commit b9d9db8

Browse files
committed
Properly escape list of messages when creating a new entry
This has been broken since day 1... oops. Noted by Vik Fearing
1 parent 6a118a0 commit b9d9db8

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

pgcommitfest/commitfest/static/commitfest/js/commitfest.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ function findLatestThreads() {
2020
sel = $('#attachThreadList');
2121
sel.find('option').remove();
2222
$.each(data, function(m,i) {
23-
sel.append('<option value="' + i.msgid + '">' + i.from + ': ' + i.subj + ' (' + i.date + ')</option>');
23+
sel.append($('<option/>').text(i.from + ': ' + i.subj + ' (' + i.date + ')').val(i.msgid));
2424
});
2525
}).always(function() {
2626
$('#attachThreadListWrap').removeClass('loading');

0 commit comments

Comments
 (0)