tests: final Windows fixes

Author: gsmolk

tests/Readme.md

@@ -1,7 +1,11 @@
 [см wiki](https://confluence.postgrespro.ru/display/DEV/pg_probackup)
 
 ```
-Note: For now there are tests only for Linix
+Note: For now these are works on Linix and "kinda" works on Windows
+```
+
+```
+Windows Note: For tablespaceses tests to work on Windows, you should explicitly(!) grant current user full access to tmp_dirs
 ```
 
 

tests/__init__.py

@@ -1,6 +1,6 @@
 import unittest
 
-from . import init_test, merge, option_test, show_test, compatibility, \
+from . import init, merge, option, show, compatibility, \
     backup_test, delete, delta, restore, validate, \
     retention, pgpro560, pgpro589, pgpro2068, false_positive, replica, \
     compression, page, ptrack, archive, exclude, cfs_backup, cfs_restore, \
@@ -19,40 +19,36 @@ def load_tests(loader, tests, pattern):
 #    suite.addTests(loader.loadTestsFromModule(cfs_backup))
 #    suite.addTests(loader.loadTestsFromModule(cfs_restore))
 #    suite.addTests(loader.loadTestsFromModule(cfs_validate_backup))
-    suite.addTests(loader.loadTestsFromModule(logging))
     suite.addTests(loader.loadTestsFromModule(compression))
     suite.addTests(loader.loadTestsFromModule(delete))
     suite.addTests(loader.loadTestsFromModule(delta))
     suite.addTests(loader.loadTestsFromModule(exclude))
+    suite.addTests(loader.loadTestsFromModule(external))
     suite.addTests(loader.loadTestsFromModule(false_positive))
-    suite.addTests(loader.loadTestsFromModule(init_test))
+    suite.addTests(loader.loadTestsFromModule(init))
     suite.addTests(loader.loadTestsFromModule(locking))
     suite.addTests(loader.loadTestsFromModule(logging))
     suite.addTests(loader.loadTestsFromModule(merge))
-    suite.addTests(loader.loadTestsFromModule(option_test))
+    suite.addTests(loader.loadTestsFromModule(option))
     suite.addTests(loader.loadTestsFromModule(page))
 #    suite.addTests(loader.loadTestsFromModule(ptrack))
+    suite.addTests(loader.loadTestsFromModule(pgpro560))
+    suite.addTests(loader.loadTestsFromModule(pgpro589))
+    suite.addTests(loader.loadTestsFromModule(pgpro2068))
     suite.addTests(loader.loadTestsFromModule(remote))
     suite.addTests(loader.loadTestsFromModule(replica))
     suite.addTests(loader.loadTestsFromModule(restore))
     suite.addTests(loader.loadTestsFromModule(retention))
-    suite.addTests(loader.loadTestsFromModule(show_test))
+    suite.addTests(loader.loadTestsFromModule(show))
     suite.addTests(loader.loadTestsFromModule(snapfs))
-    suite.addTests(loader.loadTestsFromModule(validate))
-    suite.addTests(loader.loadTestsFromModule(pgpro560))
-    suite.addTests(loader.loadTestsFromModule(pgpro589))
-    suite.addTests(loader.loadTestsFromModule(pgpro2068))
     suite.addTests(loader.loadTestsFromModule(time_stamp))
-    suite.addTests(loader.loadTestsFromModule(external))
+    suite.addTests(loader.loadTestsFromModule(validate))
 
     return suite
 
 #   test_pgpro434_2 unexpected success
 # ToDo:
-#  archive:
-#    discrepancy of instance`s SYSTEMID and node`s SYSTEMID should lead to archive-push refusal to work
 #  logging:
-#     https://jira.postgrespro.ru/browse/PGPRO-584
 #     https://jira.postgrespro.ru/secure/attachment/20420/20420_doc_logging.md
 # archive:
 #      immediate recovery and full recovery

tests/exclude.py

@@ -112,9 +112,8 @@ def test_exclude_unlogged_tables_1(self):
             set_replication=True,
             initdb_params=['--data-checksums'],
             pg_options={
-                'max_wal_senders': '2',
+                'autovacuum': 'off',
                 "shared_buffers": "10MB",
-                "fsync": "off",
                 'ptrack_enable': 'on'})
 
         self.init_pb(backup_dir)

tests/logging.py

@@ -256,7 +256,7 @@ def test_garbage_in_rotation_file(self):
         self.assertTrue(os.path.isfile(rotation_file_path))
 
         # mangle .rotation file
-        with open(rotation_file_path, "wtb", 0) as f:
+        with open(rotation_file_path, "wt", 0) as f:
             f.write(b"blah")
             f.flush()
             f.close
@@ -274,8 +274,11 @@ def test_garbage_in_rotation_file(self):
             log_file_size)
 
         self.assertIn(
-            'WARNING: rotation file "{0}" has wrong '
-            'creation timestamp'.format(rotation_file_path),
+            'WARNING: rotation file',
+            output)
+
+        self.assertIn(
+            'has wrong creation timestamp',
             output)
 
         self.assertTrue(os.path.isfile(rotation_file_path))

tests/merge.py

@@ -1224,7 +1224,8 @@ def test_continue_failed_merge_2(self):
 
         gdb = self.merge_backup(backup_dir, "node", backup_id, gdb=True)
 
-        gdb.set_breakpoint('fio_unlink')
+        gdb.set_breakpoint('pgFileDelete')
+
         gdb.run_until_break()
 
         gdb.continue_execution_until_break(20)