[PBCKP-314] rewrite fio_mkdir to use pio

Author: Sergey Fukanchik

src/utils/file.c

@@ -1536,32 +1536,8 @@ dir_create_dir(const char *dir, mode_t mode, bool strict)
 int
 fio_mkdir(fio_location location, const char* path, int mode, bool strict)
 {
-	if (fio_is_remote(location))
-	{
-		fio_header hdr = {
-			.cop = FIO_MKDIR,
-			.handle = strict ? 1 : 0, /* ugly "hack" to pass more params*/
-			.size = strlen(path) + 1,
-			.arg = mode,
-		};
-
-		IO_CHECK(fio_write_all(fio_stdout, &hdr, sizeof(hdr)), sizeof(hdr));
-		IO_CHECK(fio_write_all(fio_stdout, path, hdr.size), hdr.size);
-
-		IO_CHECK(fio_read_all(fio_stdin, &hdr, sizeof(hdr)), sizeof(hdr));
-		Assert(hdr.cop == FIO_MKDIR);
-
-		if (hdr.arg != 0)
-		{
-			errno = hdr.arg;
-			return -1;
-		}
-		return 0;
-	}
-	else
-	{
-		return dir_create_dir(path, mode, strict);
-	}
+	pioDrive_i drive = pioDriveForLocation(location);
+	return $i(pioMakeDir, drive, .path = path, .mode = mode, .strict = strict);
 }
 
 static void
@@ -4136,6 +4112,13 @@ pioLocalDrive_pioIsRemote(VSelf)
     return false;
 }
 
+static int
+pioLocalDrive_pioMakeDir(VSelf, const char *path, mode_t mode, bool strict)
+{
+  FOBJ_FUNC_ARP();
+  return dir_create_dir(path, mode, strict);
+}
+
 static void
 pioLocalDrive_pioListDir(VSelf, parray *files, const char *root, bool handle_tablespaces,
                          bool follow_symlink, bool backup_logs, bool skip_hidden,
@@ -4452,6 +4435,31 @@ pioRemoteDrive_pioIsRemote(VSelf)
     return true;
 }
 
+static int
+pioRemoteDrive_pioMakeDir(VSelf, const char *path, mode_t mode, bool strict)
+{
+    FOBJ_FUNC_ARP();
+		fio_header hdr = {
+			.cop = FIO_MKDIR,
+			.handle = strict ? 1 : 0, /* ugly "hack" to pass more params*/
+			.size = strlen(path) + 1,
+			.arg = mode,
+		};
+
+		IO_CHECK(fio_write_all(fio_stdout, &hdr, sizeof(hdr)), sizeof(hdr));
+		IO_CHECK(fio_write_all(fio_stdout, path, hdr.size), hdr.size);
+
+		IO_CHECK(fio_read_all(fio_stdin, &hdr, sizeof(hdr)), sizeof(hdr));
+		Assert(hdr.cop == FIO_MKDIR);
+
+		if (hdr.arg != 0)
+		{
+			errno = hdr.arg;
+			return -1;
+		}
+		return 0;
+}
+
 static void
 pioRemoteDrive_pioListDir(VSelf, parray *files, const char *root, bool handle_tablespaces,
                           bool follow_symlink, bool backup_logs, bool skip_hidden,

src/utils/file.h

@@ -254,6 +254,7 @@ typedef struct stat stat_t;
 #define mth__pioGetCRC32 	pg_crc32, (path_t, path), (bool, compressed), \
 									  (err_i *, err)
 #define mth__pioIsRemote 	bool
+#define mth__pioMakeDir int, (const char *, path), (mode_t, mode), (bool, strict)
 #define mth__pioListDir     void, (parray *, files), (const char *, root), \
                                 (bool, handle_tablespaces), (bool, symlink_and_hidden), \
                                 (bool, backup_logs), (bool, skip_hidden),  (int, external_dir_num)
@@ -266,12 +267,12 @@ fobj_method(pioRename);
 fobj_method(pioExists);
 fobj_method(pioIsRemote);
 fobj_method(pioGetCRC32);
+fobj_method(pioMakeDir);
 fobj_method(pioListDir);
 fobj_method(pioRemoveDir);
 
 #define iface__pioDrive 	mth(pioOpen, pioStat, pioRemove, pioRename), \
-					        mth(pioExists, pioGetCRC32, pioIsRemote),                \
-							mth(pioListDir, pioRemoveDir)
+    mth(pioExists, pioGetCRC32, pioIsRemote, pioMakeDir, pioListDir, pioRemoveDir)
 fobj_iface(pioDrive);
 
 extern pioDrive_i pioDriveForLocation(fio_location location);