Use InvalidXLogRecPtr to mark infinite end, a couple code cleanup

Author: za-arthur

src/backup.c

@@ -474,6 +474,7 @@ do_backup_instance(void)
 
 	pgBackup   *prev_backup = NULL;
 	parray	   *prev_backup_filelist = NULL;
+	parray	   *backup_list = NULL;
 
 	pgFile	   *pg_control = NULL;
 
@@ -515,7 +516,6 @@ do_backup_instance(void)
 		current.backup_mode == BACKUP_MODE_DIFF_PTRACK ||
 		current.backup_mode == BACKUP_MODE_DIFF_DELTA)
 	{
-		parray	   *backup_list;
 		char		prev_backup_filelist_path[MAXPGPATH];
 
 		/* get list of backups already taken */
@@ -525,7 +525,6 @@ do_backup_instance(void)
 		if (prev_backup == NULL)
 			elog(ERROR, "Valid backup on current timeline is not found. "
 						"Create new FULL backup before an incremental one.");
-		parray_free(backup_list);
 
 		pgBackupGetPath(prev_backup, prev_backup_filelist_path,
 						lengthof(prev_backup_filelist_path), DATABASE_FILE_LIST);
@@ -832,6 +831,13 @@ do_backup_instance(void)
 			current.data_bytes += file->write_size;
 	}
 
+	/* Cleanup */
+	if (backup_list)
+	{
+		parray_walk(backup_list, pgBackupFree);
+		parray_free(backup_list);
+	}
+
 	parray_walk(backup_files_list, pgFileFree);
 	parray_free(backup_files_list);
 	backup_files_list = NULL;

src/pg_probackup.h

@@ -418,7 +418,6 @@ extern int do_restore_or_validate(time_t target_backup_id,
 extern bool satisfy_timeline(const parray *timelines, const pgBackup *backup);
 extern bool satisfy_recovery_target(const pgBackup *backup,
 									const pgRecoveryTarget *rt);
-extern parray * readTimeLineHistory_probackup(TimeLineID targetTLI);
 extern pgRecoveryTarget *parseRecoveryTargetOptions(
 	const char *target_time, const char *target_xid,
 	const char *target_inclusive, TimeLineID target_tli, const char* target_lsn,

src/restore.c

@@ -33,6 +33,7 @@ static void restore_backup(pgBackup *backup);
 static void create_recovery_conf(time_t backup_id,
 								 pgRecoveryTarget *rt,
 								 pgBackup *backup);
+static parray *read_timeline_history(TimeLineID targetTLI);
 static void *restore_files(void *arg);
 static void remove_deleted_files(pgBackup *backup);
 
@@ -138,7 +139,7 @@ do_restore_or_validate(time_t target_backup_id, pgRecoveryTarget *rt,
 
 				elog(LOG, "target timeline ID = %u", rt->recovery_target_tli);
 				/* Read timeline history files from archives */
-				timelines = readTimeLineHistory_probackup(rt->recovery_target_tli);
+				timelines = read_timeline_history(rt->recovery_target_tli);
 
 				if (!satisfy_timeline(timelines, current_backup))
 				{
@@ -149,6 +150,9 @@ do_restore_or_validate(time_t target_backup_id, pgRecoveryTarget *rt,
 						/* Try to find another backup that satisfies target timeline */
 						continue;
 				}
+
+				parray_walk(timelines, pfree);
+				parray_free(timelines);
 			}
 
 			if (!satisfy_recovery_target(current_backup, rt))
@@ -731,7 +735,7 @@ create_recovery_conf(time_t backup_id,
  * based on readTimeLineHistory() in timeline.c
  */
 parray *
-readTimeLineHistory_probackup(TimeLineID targetTLI)
+read_timeline_history(TimeLineID targetTLI)
 {
 	parray	   *result;
 	char		path[MAXPGPATH];
@@ -820,8 +824,7 @@ readTimeLineHistory_probackup(TimeLineID targetTLI)
 	entry = pgut_new(TimeLineHistoryEntry);
 	entry->tli = targetTLI;
 	/* LSN in target timeline is valid */
-	/* TODO ensure that -1UL --> -1L fix is correct */
-	entry->end = (uint32) (-1L << 32) | -1L;
+	entry->end = InvalidXLogRecPtr;
 	parray_insert(result, 0, entry);
 
 	return result;
@@ -853,7 +856,8 @@ satisfy_timeline(const parray *timelines, const pgBackup *backup)
 
 		timeline = (TimeLineHistoryEntry *) parray_get(timelines, i);
 		if (backup->tli == timeline->tli &&
-			backup->stop_lsn < timeline->end)
+			(XLogRecPtrIsInvalid(timeline->end) ||
+			 backup->stop_lsn < timeline->end))
 			return true;
 	}
 	return false;