PGPRO-1921: fix segfault in show when backup with provided BACKUP_ID do not exists

gsmolk · gsmolk · commit 26bd9cf20ed8 · 2018-08-30T14:37:13.000+03:00
diff --git a/src/catalog.c b/src/catalog.c
@@ -561,14 +561,14 @@ readBackupControlFile(const char *path)
 		{0}
 	};
 
+	pgBackupInit(backup);
 	if (access(path, F_OK) != 0)
 	{
 		elog(WARNING, "control file \"%s\" doesn't exist", path);
 		pgBackupFree(backup);
 		return NULL;
 	}
 
-	pgBackupInit(backup);
 	parsed_options = pgut_readopt(path, options, WARNING);
 
 	if (parsed_options == 0)

Original file line number	Diff line number	Diff line change
`@@ -561,14 +561,14 @@ readBackupControlFile(const char *path)`
`561`	`561`	`{0}`
`562`	`562`	`};`
`563`	`563`
	`564`	`+ pgBackupInit(backup);`
`564`	`565`	`if (access(path, F_OK) != 0)`
`565`	`566`	`{`
`566`	`567`	`elog(WARNING, "control file \"%s\" doesn't exist", path);`
`567`	`568`	`pgBackupFree(backup);`
`568`	`569`	`return NULL;`
`569`	`570`	`}`
`570`	`571`
`571`		`- pgBackupInit(backup);`
`572`	`572`	`parsed_options = pgut_readopt(path, options, WARNING);`
`573`	`573`
`574`	`574`	`if (parsed_options == 0)`