Skip to content

Commit 2fdab7c

Browse files
committed
[Issue #120] fix tests.delete.DeleteTest.test_delete_error_backups
1 parent 3429ef1 commit 2fdab7c

File tree

1 file changed

+36
-10
lines changed

1 file changed

+36
-10
lines changed

tests/delete.py

Lines changed: 36 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -825,25 +825,51 @@ def test_delete_error_backups(self):
825825
# Take PAGE BACKUP
826826
backup_id_b = self.backup_node(backup_dir, 'node', node, backup_type="page")
827827

828+
backup_id_c = self.backup_node(backup_dir, 'node', node, backup_type="page")
829+
830+
backup_id_d = self.backup_node(backup_dir, 'node', node, backup_type="page")
831+
832+
# full backup mode
833+
self.backup_node(backup_dir, 'node', node)
834+
self.backup_node(backup_dir, 'node', node, backup_type="page")
835+
backup_id_e = self.backup_node(backup_dir, 'node', node, backup_type="page")
836+
self.backup_node(backup_dir, 'node', node, backup_type="page")
837+
828838
# Change status to ERROR
829839
self.change_backup_status(backup_dir, 'node', backup_id_a, 'ERROR')
830-
self.change_backup_status(backup_dir, 'node', backup_id_b, 'ERROR')
840+
self.change_backup_status(backup_dir, 'node', backup_id_c, 'ERROR')
841+
self.change_backup_status(backup_dir, 'node', backup_id_e, 'ERROR')
831842

832-
print(self.show_pb(backup_dir, as_text=True, as_json=False))
843+
print(self.show_pb(backup_dir, as_text=True, as_json=False))
833844

834845
show_backups = self.show_pb(backup_dir, 'node')
835-
self.assertEqual(len(show_backups), 4)
846+
self.assertEqual(len(show_backups), 10)
836847

837848
# delete error backups
838-
self.delete_pb(backup_dir, 'node', options=['--status=ERROR'])
849+
output = self.delete_pb(backup_dir, 'node', options=['--status=ERROR', '--dry-run'])
850+
show_backups = self.show_pb(backup_dir, 'node')
851+
self.assertEqual(len(show_backups), 10)
852+
853+
self.assertIn(
854+
"Deleting all backups with status 'ERROR' in dry run mode",
855+
output)
856+
857+
self.assertIn(
858+
"INFO: Backup {0} with status OK can be deleted".format(backup_id_d),
859+
output)
839860

840-
print(self.show_pb(backup_dir, as_text=True, as_json=False))
861+
print(self.show_pb(backup_dir, as_text=True, as_json=False))
841862

842863
show_backups = self.show_pb(backup_dir, 'node')
843-
self.assertEqual(len(show_backups), 2)
864+
output = self.delete_pb(backup_dir, 'node', options=['--status=ERROR'])
865+
print(output)
866+
show_backups = self.show_pb(backup_dir, 'node')
867+
self.assertEqual(len(show_backups), 4)
844868

845-
self.assertEqual(show_backups[0]['status'], "OK")
846-
self.assertEqual(show_backups[1]['status'], "OK")
869+
self.assertEqual(show_backups[0]['status'], "OK")
870+
self.assertEqual(show_backups[1]['status'], "OK")
871+
self.assertEqual(show_backups[2]['status'], "OK")
872+
self.assertEqual(show_backups[3]['status'], "OK")
847873

848-
# Clean after yourself
849-
self.del_test_dir(module_name, fname)
874+
# Clean after yourself
875+
self.del_test_dir(module_name, fname)

0 commit comments

Comments
 (0)