dot-based representation for everything except big plain tables

Author: Daniel Shelepanov

src/show.c

@@ -126,7 +126,6 @@ do_show(CatalogState *catalogState, InstanceState *instanceState,
 		requested_backup_id != INVALID_BACKUP_ID)
 		elog(ERROR, "You cannot specify --archive and (-i, --backup-id) options together");
 
-	set_output_numeric_locale(LOCALE_C);
 	/*
 	 * if instance is not specified,
 	 * show information about all instances in this backup catalog
@@ -149,7 +148,6 @@ do_show(CatalogState *catalogState, InstanceState *instanceState,
 				show_instance(instanceState, INVALID_BACKUP_ID, true);
 		}
 		show_instance_end();
-		set_output_numeric_locale(LOCALE_ENV);
 
 		return 0;
 	}
@@ -168,7 +166,6 @@ do_show(CatalogState *catalogState, InstanceState *instanceState,
 			show_instance(instanceState, requested_backup_id, false);
 
 		show_instance_end();
-		set_output_numeric_locale(LOCALE_ENV);
 
 		return 0;
 	}
@@ -182,7 +179,6 @@ do_show(CatalogState *catalogState, InstanceState *instanceState,
 		else
 			show_backup(instanceState, requested_backup_id);
 
-		set_output_numeric_locale(LOCALE_ENV);
 		return 0;
 	}
 }
@@ -555,6 +551,9 @@ show_instance_plain(const char *instance_name, parray *backup_list, bool show_na
 	ShowBackendRow *rows;
 	TimeLineID parent_tli = 0;
 
+	// Since we've been printing a table, set LC_NUMERIC to its default environment value
+	set_output_numeric_locale(LOCALE_ENV);
+
 	for (i = 0; i < SHOW_FIELDS_COUNT; i++)
 		widths[i] = strlen(names[i]);
 
@@ -768,6 +767,8 @@ show_instance_plain(const char *instance_name, parray *backup_list, bool show_na
 	}
 
 	pfree(rows);
+	// Restore the C locale
+	set_output_numeric_locale(LOCALE_C);
 }
 
 /*
@@ -848,6 +849,9 @@ show_archive_plain(const char *instance_name, uint32 xlog_seg_size,
 	uint32		widths_sum = 0;
 	ShowArchiveRow *rows;
 
+	// Since we've been printing a table, set LC_NUMERIC to its default environment value
+	set_output_numeric_locale(LOCALE_ENV);
+
 	for (i = 0; i < SHOW_ARCHIVE_FIELDS_COUNT; i++)
 		widths[i] = strlen(names[i]);
 
@@ -1015,6 +1019,8 @@ show_archive_plain(const char *instance_name, uint32 xlog_seg_size,
 	}
 
 	pfree(rows);
+	// Restore the C locale
+	set_output_numeric_locale(LOCALE_C);
 	//TODO: free timelines
 }