[Issue #203] test coverage

Author: gsmolk

tests/archive.py

@@ -977,6 +977,10 @@ def test_basic_master_and_replica_concurrent_archiving(self):
 
         replica.promote()
 
+        replica.safe_psql(
+            'postgres',
+            'CHECKPOINT')
+
         master.pgbench_init(scale=10)
         replica.pgbench_init(scale=10)
 

tests/backup.py

@@ -2511,7 +2511,7 @@ def test_backup_with_less_privileges_role(self):
         # Clean after yourself
         self.del_test_dir(module_name, fname)
 
-    # @unittest.skip("skip")
+    @unittest.skip("skip")
     def test_issue_132(self):
         """
         https://github.com/postgrespro/pg_probackup/issues/132
@@ -2546,6 +2546,8 @@ def test_issue_132(self):
         pgdata_restored = self.pgdata_content(node.data_dir)
         self.compare_pgdata(pgdata, pgdata_restored)
 
+        exit(1)
+
         # Clean after yourself
         self.del_test_dir(module_name, fname)
 

tests/config.py

@@ -3,6 +3,7 @@
 import os
 from .helpers.ptrack_helpers import ProbackupTest, ProbackupException
 from sys import exit
+from shutil import copyfile
 
 module_name = 'config'
 
@@ -51,3 +52,61 @@ def test_remove_instance_config(self):
                 e.message,
                 "\n Unexpected Error Message: {0}\n CMD: {1}".format(
                     repr(e.message), self.cmd))
+
+    # @unittest.expectedFailure
+    # @unittest.skip("skip")
+    def test_corrupt_backup_content(self):
+        """corrupt backup_content.control"""
+        fname = self.id().split('.')[3]
+        backup_dir = os.path.join(self.tmp_path, module_name, fname, 'backup')
+        node = self.make_simple_node(
+            base_dir=os.path.join(module_name, fname, 'node'),
+            set_replication=True,
+            initdb_params=['--data-checksums'])
+
+        self.init_pb(backup_dir)
+        self.add_instance(backup_dir, 'node', node)
+        self.set_archiving(backup_dir, 'node', node)
+        node.slow_start()
+
+        full1_id = self.backup_node(backup_dir, 'node', node)
+
+        node.safe_psql(
+            'postgres',
+            'create table t1()')
+
+        fulle2_id = self.backup_node(backup_dir, 'node', node)
+
+        fulle1_conf_file = os.path.join(
+            backup_dir, 'backups','node', full1_id, 'backup_content.control')
+
+        fulle2_conf_file = os.path.join(
+            backup_dir, 'backups','node', fulle2_id, 'backup_content.control')
+
+        copyfile(fulle2_conf_file, fulle1_conf_file)
+
+        try:
+            self.validate_pb(backup_dir, 'node')
+            self.assertEqual(
+                    1, 0,
+                    "Expecting Error because pg_probackup.conf is missing. "
+                    ".\n Output: {0} \n CMD: {1}".format(
+                        repr(self.output), self.cmd))
+        except ProbackupException as e:
+            self.assertIn(
+                "WARNING: Invalid CRC of backup control file '{0}':".format(fulle1_conf_file),
+                e.message,
+                "\n Unexpected Error Message: {0}\n CMD: {1}".format(
+                    repr(e.message), self.cmd))
+
+            self.assertIn(
+                "WARNING: Failed to get file list for backup {0}".format(full1_id),
+                e.message,
+                "\n Unexpected Error Message: {0}\n CMD: {1}".format(
+                    repr(e.message), self.cmd))
+
+            self.assertIn(
+                "WARNING: Backup {0} file list is corrupted".format(full1_id),
+                e.message,
+                "\n Unexpected Error Message: {0}\n CMD: {1}".format(
+                    repr(e.message), self.cmd))

tests/merge.py

@@ -1530,8 +1530,8 @@ def test_crash_after_opening_backup_control_2(self):
         gdb.set_breakpoint('write_backup_filelist')
         gdb.run_until_break()
 
-        gdb.set_breakpoint('fio_fwrite')
-        gdb.continue_execution_until_break(2)
+        gdb.set_breakpoint('sprintf')
+        gdb.continue_execution_until_break(20)
 
         gdb._execute('signal SIGKILL')
 
@@ -1621,8 +1621,8 @@ def test_losing_file_after_failed_merge(self):
         gdb.set_breakpoint('write_backup_filelist')
         gdb.run_until_break()
 
-        gdb.set_breakpoint('fio_fwrite')
-        gdb.continue_execution_until_break(2)
+        gdb.set_breakpoint('sprintf')
+        gdb.continue_execution_until_break(20)
 
         gdb._execute('signal SIGKILL')