[Issue #212] Fix logging into file for local archive-push and archive-get

Author: gsmolk

src/pg_probackup.c

@@ -561,9 +561,18 @@ main(int argc, char *argv[])
 		setMyLocation();
 	}
 
-	/* disable logging into file for archive-push and archive-get */
-	if (backup_subcmd == ARCHIVE_GET_CMD ||
-		backup_subcmd == ARCHIVE_PUSH_CMD)
+	/*
+	 * Disable logging into file for archive-push and archive-get.
+	 * Note, that we should NOT use fio_is_remote() here,
+	 * because it will launch ssh connection and we do not
+	 * want it, because it will kill archive-get prefetch
+	 * performance.
+	 *
+	 * TODO: make logging into file possible via ssh
+	 */
+	if (fio_is_remote_simple(FIO_BACKUP_HOST) &&
+		(backup_subcmd == ARCHIVE_GET_CMD ||
+		backup_subcmd == ARCHIVE_PUSH_CMD))
 	{
 		instance_config.logger.log_level_file = LOG_OFF;
 	}

src/pg_probackup.h

@@ -1036,6 +1036,7 @@ extern int fio_send_file(const char *from_fullpath, const char *to_fullpath, FIL
 
 /* Check if specified location is local for current node */
 extern bool fio_is_remote(fio_location location);
+extern bool fio_is_remote_simple(fio_location location);
 
 extern void get_header_errormsg(Page page, char **errormsg);
 extern void get_checksum_errormsg(Page page, char **errormsg,

src/utils/file.c

@@ -147,6 +147,15 @@ bool fio_is_remote(fio_location location)
 	return is_remote;
 }
 
+/* Check if specified location is local for current node */
+bool fio_is_remote_simple(fio_location location)
+{
+	bool is_remote = MyLocation != FIO_LOCAL_HOST
+		&& location != FIO_LOCAL_HOST
+		&& location != MyLocation;
+	return is_remote;
+}
+
 /* Try to read specified amount of bytes unless error or EOF are encountered */
 static ssize_t fio_read_all(int fd, void* buf, size_t size)
 {