tests: added restore.RestoreTest.test_pg_11_group_access

Author: gsmolk

tests/helpers/ptrack_helpers.py

@@ -1222,7 +1222,7 @@ def pgdata_content(self, pgdata, ignore_ptrack=True, exclude_dirs=None):
         directory_dict = {}
         directory_dict['pgdata'] = pgdata
         directory_dict['files'] = {}
-        directory_dict['dirs'] = []
+        directory_dict['dirs'] = {}
         for root, dirs, files in os.walk(pgdata, followlinks=True):
             dirs[:] = [d for d in dirs if d not in dirs_to_ignore]
             for file in files:
@@ -1267,7 +1267,18 @@ def pgdata_content(self, pgdata, ignore_ptrack=True, exclude_dirs=None):
                             break
 
                 if not found:
-                    directory_dict['dirs'].append(directory_relpath)
+                    directory_dict['dirs'][directory_relpath] = {}
+
+        # get permissions for every file and directory
+        for file in directory_dict['dirs']:
+            full_path = os.path.join(pgdata, file)
+            directory_dict['dirs'][file]['mode'] = os.stat(
+                full_path).st_mode
+
+        for file in directory_dict['files']:
+            full_path = os.path.join(pgdata, file)
+            directory_dict['files'][file]['mode'] = os.stat(
+                full_path).st_mode
 
         return directory_dict
 
@@ -1283,6 +1294,21 @@ def compare_pgdata(self, original_pgdata, restored_pgdata):
                 error_message += '\nDirectory was not present'
                 error_message += ' in original PGDATA: {0}\n'.format(
                     os.path.join(restored_pgdata['pgdata'], directory))
+            else:
+                if (
+                    restored_pgdata['dirs'][directory]['mode'] !=
+                    original_pgdata['dirs'][directory]['mode']
+                ):
+                    fail = True
+                    error_message += '\nDir permissions mismatch:\n'
+                    error_message += ' Dir old: {0} Permissions: {1}\n'.format(
+                        os.path.join(original_pgdata['pgdata'], directory),
+                        original_pgdata['dirs'][directory]['mode'])
+                    error_message += ' Dir new: {0} Permissions: {1}\n'.format(
+                        os.path.join(restored_pgdata['pgdata'], directory),
+                        restored_pgdata['dirs'][directory]['mode'])
+
+
 
         for directory in original_pgdata['dirs']:
             if directory not in restored_pgdata['dirs']:
@@ -1305,6 +1331,19 @@ def compare_pgdata(self, original_pgdata, restored_pgdata):
         for file in original_pgdata['files']:
             if file in restored_pgdata['files']:
 
+                if (
+                    restored_pgdata['files'][file]['mode'] !=
+                    original_pgdata['files'][file]['mode']
+                ):
+                    fail = True
+                    error_message += '\nFile permissions mismatch:\n'
+                    error_message += ' File_old: {0} Permissions: {1}\n'.format(
+                        os.path.join(original_pgdata['pgdata'], file),
+                        original_pgdata['files'][file]['mode'])
+                    error_message += ' File_new: {0} Permissions: {1}\n'.format(
+                        os.path.join(restored_pgdata['pgdata'], file),
+                        restored_pgdata['files'][file]['mode'])
+
                 if (
                     original_pgdata['files'][file]['md5'] !=
                     restored_pgdata['files'][file]['md5']

tests/restore.py

@@ -2152,3 +2152,44 @@ def test_smart_restore(self):
 
         # Clean after yourself
         self.del_test_dir(module_name, fname)
+
+    # @unittest.skip("skip")
+    def test_pg_11_group_access(self):
+        """
+        test group access for PG >= 11
+        """
+        fname = self.id().split('.')[3]
+        node = self.make_simple_node(
+            base_dir=os.path.join(module_name, fname, 'node'),
+            set_replication=True,
+            initdb_params=[
+                '--data-checksums',
+                '--allow-group-access'])
+
+        backup_dir = os.path.join(self.tmp_path, module_name, fname, 'backup')
+        self.init_pb(backup_dir)
+        self.add_instance(backup_dir, 'node', node)
+        node.slow_start()
+
+        if self.get_version(node) < self.version_to_num('11.0'):
+            return unittest.skip('You need PostgreSQL >= 11 for this test')
+
+        # take FULL backup
+        self.backup_node(backup_dir, 'node', node, options=['--stream'])
+
+        pgdata = self.pgdata_content(node.data_dir)
+
+        # restore backup
+        node_restored = self.make_simple_node(
+            base_dir=os.path.join(module_name, fname, 'node_restored'))
+        node_restored.cleanup()
+
+        self.restore_node(
+            backup_dir, 'node', node_restored)
+
+        # compare pgdata permissions
+        pgdata_restored = self.pgdata_content(node_restored.data_dir)
+        self.compare_pgdata(pgdata, pgdata_restored)
+
+        # Clean after yourself
+        self.del_test_dir(module_name, fname)