[Issue #238] in PG>=12 use postgresql.auto.conf for recovery parameters

Author: gsmolk

src/pg_probackup.c

@@ -99,7 +99,7 @@ static pgRecoveryTarget *recovery_target_options = NULL;
 static pgRestoreParams *restore_params = NULL;
 
 time_t current_time = 0;
-bool restore_as_replica = false;
+static bool restore_as_replica = false;
 bool no_validate = false;
 IncrRestoreMode incremental_mode = INCR_NONE;
 
@@ -705,15 +705,14 @@ main(int argc, char *argv[])
 		if (force)
 			no_validate = true;
 
-		if (replication_slot != NULL)
-			restore_as_replica = true;
-
 		/* keep all params in one structure */
 		restore_params = pgut_new(pgRestoreParams);
 		restore_params->is_restore = (backup_subcmd == RESTORE_CMD);
 		restore_params->force = force;
 		restore_params->no_validate = no_validate;
 		restore_params->restore_as_replica = restore_as_replica;
+		restore_params->recovery_settings_mode = DEFAULT;
+
 		restore_params->primary_slot_name = replication_slot;
 		restore_params->skip_block_validation = skip_block_validation;
 		restore_params->skip_external_dirs = skip_external_dirs;

src/pg_probackup.h

@@ -146,6 +146,16 @@ typedef enum PartialRestoreType
 	EXCLUDE,
 } PartialRestoreType;
 
+typedef enum RecoverySettingsMode
+{
+	DEFAULT,	/* not set */
+	DONTWRITE,	/* explicitly forbid to update recovery settings */
+				//TODO Should we always clean/preserve old recovery settings,
+				// or make it configurable?
+	PITR_REQUESTED, /* can be set based on other parameters
+	                 * if not explicitly forbidden */
+} RecoverySettingsMode;
+
 typedef enum CompressAlg
 {
 	NOT_DEFINED_COMPRESS = 0,
@@ -490,6 +500,8 @@ typedef struct pgRestoreParams
 	bool	is_restore;
 	bool	no_validate;
 	bool	restore_as_replica;
+	//TODO maybe somehow add restore_as_replica as one of RecoverySettingsModes
+	RecoverySettingsMode recovery_settings_mode;
 	bool	skip_external_dirs;
 	bool	skip_block_validation; //Start using it
 	const char *restore_command;